Open DrewBrasher opened 10 months ago
Do you need any help on this?
@hishamco I've started outlining some definitions and things the project needs to have in the readme.md file. Feel free to add or change anything or let me know and I can add/change it.
I do have a couple of questions.
Should I add Models, Drivers, Handlers, Views, ViewModels, and Settings for every content part or are some of these usually only added if needed?
Since Projects and Issues need a lot of the same information, What do you think would be the best way to design that? Would we have a part that has all of that information and then add that part to both Issue and Project content types?
Should I add Models, Drivers, Handlers, Views, ViewModels, and Settings for every content part or are some of these usually only added if needed?
It depends
Since Projects and Issues need a lot of the same information
I think we should create a content type for each. Please list to me the shared information.
I think we should create a content type for each. Please list to me the shared information.
While there's no notion of content type inheritance using fields and parts might suited in this case even though there are several common properties
It thought about having a Part that has Fields for all the stuff both Issues and Projects need and then adding that Part to the Issue and Project content types.
I usually add a part if it's fit to be reusable across content types and could add certain functionality, for now, let's make it simple
Please add a check list for this module so we can make progress, and avoid conflict
I have a checklist in the readme file or is there some other checklist I should create?
Please add them again in the issue description, so we can keep track of this module
Please add them again in the issue description, so we can keep track of this module
I've added the checklist to the issue description.
I usually add a part if it's fit to be reusable across content types and could add certain functionality, for now, let's make it simple
Should I deleted all the IssuePart files highlighted in https://github.com/OrchardCoreContrib/OrchardCoreContrib.Modules/pull/109#issuecomment-1924317799 and just create content types for Issue and Project in the migration file without creating Parts for them?
It depends, I usually use content type unless there's a set of fields that are reusable in multiple content types. IMHO let's accelerate the process and make progress in this, then we can revise and improve the module
Please let me know if you need help at any stage
I've never created a module with content types in the code before. I've only created a theme module and for the content types I created them in the UI and then exported the recipe and added that to my theme. So I'm learning how to do this as I go.
I just found https://github.com/Lombiq/Helpful-Extensions?tab=readme-ov-file#content-definition-code-generation and I think I will try using that method to create the content types.
I've never created a module with content types in the code before
You can create a content type programmatically through migration, I will share piece of code If you like to know how it's done
Do you need any help on this?
Do you need any help on this?
Will you take a look at commit https://github.com/OrchardCoreContrib/OrchardCoreContrib.Modules/pull/109/commits/21762e9f21b1aa6a810e41f2ab4da3244fba7a4d and let me know if I'm on the right track?
Please fix a conflict and have a look at my comments I might need to add a few commits
For Issue https://github.com/OrchardCoreContrib/OrchardCoreContrib.Modules/issues/101