OrchardCoreContrib / OrchardCoreContrib.Modules

Unofficial Orchard Core modules that driven by the community who love Orchard Core CMS
BSD 3-Clause "New" or "Revised" License
38 stars 13 forks source link

Issue tracker module #109

Open DrewBrasher opened 10 months ago

DrewBrasher commented 10 months ago

For Issue https://github.com/OrchardCoreContrib/OrchardCoreContrib.Modules/issues/101

hishamco commented 10 months ago

Do you need any help on this?

DrewBrasher commented 9 months ago

@hishamco I've started outlining some definitions and things the project needs to have in the readme.md file. Feel free to add or change anything or let me know and I can add/change it.

I do have a couple of questions.

  1. Should I add Models, Drivers, Handlers, Views, ViewModels, and Settings for every content part or are some of these usually only added if needed?

    image
  2. Since Projects and Issues need a lot of the same information, What do you think would be the best way to design that? Would we have a part that has all of that information and then add that part to both Issue and Project content types?

hishamco commented 9 months ago

Should I add Models, Drivers, Handlers, Views, ViewModels, and Settings for every content part or are some of these usually only added if needed?

It depends

Since Projects and Issues need a lot of the same information

I think we should create a content type for each. Please list to me the shared information.

DrewBrasher commented 9 months ago

I think we should create a content type for each. Please list to me the shared information.

Common to both an Issue and a Project

https://github.com/DrewBrasher/OrchardCoreContrib.Modules/tree/IssueTrackerModule/src/OrchardCoreContrib.IssueTracker#common-to-both-an-issue-and-a-project

hishamco commented 9 months ago

While there's no notion of content type inheritance using fields and parts might suited in this case even though there are several common properties

DrewBrasher commented 9 months ago

It thought about having a Part that has Fields for all the stuff both Issues and Projects need and then adding that Part to the Issue and Project content types.

hishamco commented 9 months ago

I usually add a part if it's fit to be reusable across content types and could add certain functionality, for now, let's make it simple

Please add a check list for this module so we can make progress, and avoid conflict

DrewBrasher commented 9 months ago

I have a checklist in the readme file or is there some other checklist I should create?

hishamco commented 9 months ago

Please add them again in the issue description, so we can keep track of this module

DrewBrasher commented 7 months ago

Please add them again in the issue description, so we can keep track of this module

I've added the checklist to the issue description.

DrewBrasher commented 7 months ago

I usually add a part if it's fit to be reusable across content types and could add certain functionality, for now, let's make it simple

Should I deleted all the IssuePart files highlighted in https://github.com/OrchardCoreContrib/OrchardCoreContrib.Modules/pull/109#issuecomment-1924317799 and just create content types for Issue and Project in the migration file without creating Parts for them?

hishamco commented 7 months ago

It depends, I usually use content type unless there's a set of fields that are reusable in multiple content types. IMHO let's accelerate the process and make progress in this, then we can revise and improve the module

Please let me know if you need help at any stage

DrewBrasher commented 7 months ago

I've never created a module with content types in the code before. I've only created a theme module and for the content types I created them in the UI and then exported the recipe and added that to my theme. So I'm learning how to do this as I go.

DrewBrasher commented 7 months ago

I just found https://github.com/Lombiq/Helpful-Extensions?tab=readme-ov-file#content-definition-code-generation and I think I will try using that method to create the content types.

hishamco commented 7 months ago

I've never created a module with content types in the code before

You can create a content type programmatically through migration, I will share piece of code If you like to know how it's done

hishamco commented 6 months ago

Do you need any help on this?

DrewBrasher commented 6 months ago

Do you need any help on this?

Will you take a look at commit https://github.com/OrchardCoreContrib/OrchardCoreContrib.Modules/pull/109/commits/21762e9f21b1aa6a810e41f2ab4da3244fba7a4d and let me know if I'm on the right track?

hishamco commented 6 months ago

Please fix a conflict and have a look at my comments I might need to add a few commits