search

OrchardCoreContrib / OrchardCoreContrib.Modules

Unofficial Orchard Core modules that driven by the community who love Orchard Core CMS
BSD 3-Clause "New" or "Revised" License
38 stars 13 forks source link

Add GrapesJs Editor #35

Closed hishamco closed 2 years ago

hishamco commented 2 years ago

Adding Graphes JS editor in HTML Module

/cc @kudryavtsevda

hishamco commented 2 years ago

@kudryavtsevda any progress on this? Could you please share what you did here, so I can help if it's possible

kudryavtsevda commented 2 years ago

@hishamco yep. please see my pr https://github.com/OrchardCoreContrib/OrchardCoreContrib.Modules/pull/51

hishamco commented 2 years ago

I merged the intial work that started by us, hopefully if you can address that two issues, then we can release an a beta release soon

kudryavtsevda commented 2 years ago

@hishamco check it out https://github.com/OrchardCoreContrib/OrchardCoreContrib.Modules/pull/54

I can't reproduce unsuccessful saving into database. I see all my changes in db

hishamco commented 2 years ago

I can't reproduce unsuccessful saving into database. I see all my changes in db

Could you please share a GIF screenshot showing how to add 2 or 3 columns add an image and simple text and hit save

kudryavtsevda commented 2 years ago

check it out

screen-capture (2)

hishamco commented 2 years ago

I will need to double check in my laptop, one more thing do you think that we need add anything else for now or we can ship the first beta release

Still I believe adding the OC widgets into the blocks will be a good enhancement

hishamco commented 2 years ago

You are right, everything is looks good

hishamco commented 2 years ago

FYI https://www.nuget.org/packages/OrchardCoreContrib.Html/1.0.0-beta1

hishamco commented 2 years ago

@kudryavtsevda it would be nice if you demo this feature in the upcoming OC standup meeting, thanks for the great work

kudryavtsevda commented 2 years ago

@hishamco could you tell me about it more?

hishamco commented 2 years ago

The Orchard Core is doing a standup meeting almost every Tuesday, the team show the current status, discussing topics and show demos, please check https://orchardcore.net/ to get the Microsoft Teams link

Also you can check the previous videos on Lombiq YouTube channel

hishamco commented 2 years ago

I think it's a good chance to show what you did in OCC, and go through a demo of how to enable the feature and use the GrapesJS editor, also you can talk about the future enhancements which I'm glad to discuss with you

hishamco commented 2 years ago

@kudryavtsevda last week three of OCC modules demoed, I'm still encourgh you to demo the work you did in GrapesJs editor in the next stand up meeting if it's possible

kudryavtsevda commented 2 years ago

@kudryavtsevda last week three of OCC modules demoed, I'm still encourgh you to demo the work you did in GrapesJs editor in the next stand up meeting if it's possible

Sorry I replied you in your email hishamco_2007@yahoo.com

hishamco commented 2 years ago

I didn't check my Yahoo email for awhile, let me check and come back to you

hishamco commented 2 years ago

The module is originally created by me, but polished and completed by your efforts, I appreciated the idea is you can demo it to let the OC community what you did, get the feedback also possible enhancements in the future

We can chat via gitter if you are interested ..