search

OrchardCoreContrib / OrchardCoreContrib.PoExtractor

Extracts localizable strings from .cs, .vb, .cshtml and .liquid files into POT files
MIT License
48 stars 35 forks source link

Missing translations from .cshtml files #31

Closed agriffard closed 4 years ago

agriffard commented 4 years ago

With the latest prerelease (https://www.nuget.org/packages/PoExtractor.OrchardCore/0.3.0-beta3-71077) or release (https://www.nuget.org/packages/PoExtractor.OrchardCore/0.2.0) versions of the dot net tool, some tanslations in .cshtml files are not generated when we execute : extractpo-oc D:\Orchard\OrchardCore C:\temp\OrchardCore --liquid

Ex: It removes the strings that exist in .cshtml files in OrchardCore.Admin and many others.

Can you please have a look @lukaskabrt ?

lukaskabrt commented 4 years ago

@hishamco removed T accessor in PR #25 because according to https://github.com/OrchardCMS/OrchardCore/pull/5182#issuecomment-570379047, there should be a new convention for names of localizer accessors.

If T is still used in some places, I can add it back ...

agriffard commented 4 years ago

Yes, please readd it, it is still used everywhere.

hishamco commented 4 years ago

@hishamco removed T accessor in PR #25

I think I remove them from code not the view, let me double check again

Yes, please readd it, it is still used everywhere.

My suggestion to fix it in OC because we already started this, furthermore we can create a code analyzer to fix such issue

If sound is good I can start work on it, meanwhile I can scan entire OC source to remove the inconsistent localizer names

lukaskabrt commented 4 years ago

I added T back in #32. If it is removed from OC, it can be removed from PoExtractor again.

agriffard commented 4 years ago

Thank you @lukaskabrt

hishamco commented 4 years ago

I added T back in #32

No need to remove T at all because it will be used in the views only