Closed VincenzoCarlino closed 2 months ago
It would be nice to have few unit tests, there're many corner cases that we need to test, to ensure nothing is broken
Look at this commit
It's a preview of some kinds of test we can do. All code is inside the main static function, so we can test it as I've done it in this commit, or we try to extract the code from main in something more testable. Let me know if you like it.
Thanks, @VincenzoCarlino, we might need to test more cases such as if there's a PO file with the same specified file
Thanks, @VincenzoCarlino, we might need to test more cases such as if there's a PO file with the same specified file
Yes @hishamco , this is just an example of the structure of tests. Tomorrow I'll add more tests.
Please fix the build
Hi @hishamco , I think that we don't have an easy way to test output files... using the real filesystem in the pipeline is not a good option. Do you have any suggestions?
Let me try ..
Ok @hishamco I'll wait for your commit, let me know if I can do something.
Sorry for the late, I will struggle to have a look today because we need to finalize this and publish a release before Orchard Core 2.0.0
Sorry for the late, I will struggle to have a look today because we need to finalize this and publish a release before Orchard Core 2.0.0
Hello, any update? Thanks @hishamco
Seems I forgot this one, let me check it tonight if it's possible. My plan to publish a release ASAP and will be a part of OC 2.0.0
I suggest trying this PR from Program.cs
then we can focus on make the CLI commands testable
@VincenzoCarlino please remove the changes in the test project, then I will merge, this not take so long to merge
Thanks for your contribution @VincenzoCarlino
Implementation of: #93