added modern business theme

OrchardCoreContrib / OrchardCoreContrib.Themes

Unofficial Orchard Core themes that driven by the community who love Orchard Core CMS

BSD 3-Clause "New" or "Revised" License

17 stars 9 forks source link

added modern business theme #1

Closed jwu-au closed 4 years ago

hishamco commented 4 years ago

@jwu-au thanks for your contribution, could please add a snapshot for your theme, also we need to add a reference to the OrchardCoreContrib.Themes.Web so anyone can see it in action

I think I need to update the README.md for the last step

jwu-au commented 4 years ago

@hishamco Is the Theme.png in wwwroot folder the snapshot you're looking for? I'll add the reference in web project.

jwu-au commented 4 years ago

I might missed understood the src folder you refer to. In the PR, I actually placed a physical src folder in the source control, and the theme folder under it. Or do you mean the virtual src folder in VS? Please clarify.

hishamco commented 4 years ago

the snapshot you're looking for?

Just a snapshot of how the theme is look like, paste it here

I actually placed a physical src folder in the source control, and the theme folder under it. Or do you mean the virtual src folder in VS

Please add it in both

jwu-au commented 4 years ago

The original theme template will be: https://startbootstrap.com/templates/modern-business/

Snapshot: alt text

jwu-au commented 4 years ago

Changes made:

Updated reference to latest preview 1.0.0-rc1-13334, the theme is built on top of the latest dev branch, it won't work with RC1. As RC2 is coming soon or later, this shouldn't be a big issue, right?
As the project/assembly name of theme is changed to OrchardCoreContrib.Themes.ModernBusiness, I ended up to changed some paths in Layout file so it can locate the resources. The original name of theme is called TheModernBusinessTheme.

Other than above, the theme is setup successfully via receipt and running ok.

@hishamco for you to review and test.

hishamco commented 4 years ago

Nah, seems I did something wrong with the project skeleton, I will fix it on this repo, then you can rebase after I check your theme

Thanks

hishamco commented 4 years ago

@jwu-au please rebase on the dev, BTW I don't think we need to add a folder for each theme, just add it directly on the src folder

Sorry for my bad, I didn't realize that I made a mistake on the project skeleton until I saw your PR

Thanks again