suggestion: add `PyPlot.show()` to examples

OrchardLANL / DPFEHM.jl

DPFEHM: A Differentiable Subsurface Flow Simulator

Other

30 stars 13 forks source link

suggestion: add `PyPlot.show()` to examples #10

Closed WilkAndy closed 2 years ago

WilkAndy commented 2 years ago

Currently, the plotting in examples/groundwater_steadystate.jl does not produce a figure.

Feel free to close this issue if you think it's irrelevant.

WilkAndy commented 2 years ago

Refs https://github.com/openjournals/joss-reviews/issues/4560

omalled commented 2 years ago

I've gone with the display(fig) approach to show the figures. In my tests, it works inside a Jupyter notebook and in the terminal with TerminalExtensions (my main approach). Oddly, PyPlot.show doesn't show a figure for me. Instead, it prints text in both Jupyter and the terminal. I'm going to leave it as is, but it would be nice to have something that works more universally.