search

OrchidTechnologies / orchid

Orchid: VPN, Personal Firewall
https://www.orchid.com/
GNU Affero General Public License v3.0
655 stars 102 forks source link

Adjusting to use git endpoints #11

Closed Russell-IO closed 4 years ago

saurik commented 4 years ago

The git protocol is unencrypted and really should not be used. I realize that some people disagree with this opinion, but most people also don't know much about the git "smart" HTTP protocol. Sites like GitHub have long started defaulting to encrypted HTTPS endpoints for anonymous users, and we should prefer those endpoints if at all possible. (And, if nothing else, GNU Savannah does not even document support for the git protocol.) AFAIK, this is coming up because GNU Savannah is offline right now... but that's certainly a temporary issue that will be fixed in the morning, and should not lead to workarounds being applied permanently to codebases. (Regardless, I would recommend anyone running into this issue in the meantime to not modify the .gitmodules file, and instead configure a local mirror override for these folders.)

Russell-IO commented 4 years ago

@saurik - you may want to adjust gnulib in this case https://github.com/OrchidProtocol/orchid/blob/master/.gitmodules#L112-L114

saurik commented 4 years ago

Very good catch! I have left myself a note to do that at some point when Savannah is online.