search

OrchidTechnologies / orchid

Orchid: VPN, Personal Firewall
https://www.orchid.com/
GNU Affero General Public License v3.0
655 stars 102 forks source link

Fix DAPP run time/build error when no wallet is loaded and update apple-touch-icon #22

Closed CalebBabin closed 4 years ago

CalebBabin commented 4 years ago

I set up the DAPP on my own machine and noticed a couple of issues.

This PR:

  1. Adds a return statement after the DAPP resolves the wallet status as non-existent to prevent it from continuing to call Web3 functions.
  2. Updates the react logo referenced in the "apple-touch-icon" meta tag to be the Orchid logo.

Let me know if I need to split this into two separate PRs.

patniemeyer commented 4 years ago

@CalebBabin Looks great! Thanks. Please feel free to hit the merge button if you are ready.

CalebBabin commented 4 years ago

@CalebBabin Looks great! Thanks. Please feel free to hit the merge button if you are ready.

@patniemeyer I don't have write access to this repository.

patniemeyer commented 4 years ago

Merged! Thanks.

Pat

On Jan 29, 2020, at 8:53 AM, Caleb notifications@github.com wrote:

@CalebBabin https://github.com/CalebBabin Looks great! Thanks. Please feel free to hit the merge button if you are ready.

@patniemeyer https://github.com/patniemeyer I don't have write access to this repository.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OrchidTechnologies/orchid/pull/22?email_source=notifications&email_token=AAGQD55L2RUZBCUVZXKJLI3RAGKAFA5CNFSM4KM4EXH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKHOXBY#issuecomment-579791751, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGQD52TLNLFPIVEVF7DTQ3RAGKAFANCNFSM4KM4EXHQ.