search

OrchidTechnologies / orchid

Orchid: VPN, Personal Firewall
https://www.orchid.com/
GNU Affero General Public License v3.0
655 stars 102 forks source link

Rounding Error causes Insufficient Fund Glitch #48

Closed David-Berlin closed 3 years ago

David-Berlin commented 4 years ago

When loading the DApp at account.orchid.com and prompted to fund your account, the DApp rounds the funding amount to two decimal places. If this causes the amount to be rounded up, the user receives an insufficient funds error. Either do not round the value (best option, in my opinion) or, instead of rounding, use a floor function.

saurik commented 3 years ago

I have been told that this was fixed: "I implemented a fix / guard to prevent it from every trying to spend more than the available wallet"; if this is still an issue, please re-open this issue (or potentially file a new one if it feels different).