search

OrchidTechnologies / orchid

Orchid: VPN, Personal Firewall
https://www.orchid.com/
GNU Affero General Public License v3.0
649 stars 103 forks source link

Needs zipalign #84

Closed chrishobcroft closed 3 years ago

chrishobcroft commented 3 years ago

Process fails with:

orchid@revolver:~/orchid/app-android$ make
grep: ./vpn/shared/./quickjs/*.c: No such file or directory
makefile:90: *** unable to find zipalign. Stop.

Installing zipalign gets us past that error and onto the next one.

saurik commented 3 years ago

There doesn't actually seem to be an "issue" here, as "yes: we absolutely need zipalign". My best guess for how to make this a "reasonable issue" is that you have the Android SDK installed to a non-standard path and additionally don't have ANDROID_HOME set, under an expectation that I should be using ANDROID_SDK_ROOT (as the former is "deprecated")? Regardless: I have updated the environment variable support in f30b3f7a5145623851e902145f17625154b37311 (and left a note about another use that is not so important to update quickly).

chrishobcroft commented 3 years ago

This wasn't an issue. I'm trying not to bombard you with issues.

This was a PR, to add something to the docs, to increase coverage.