search

OrchidTechnologies / orchid

Orchid: VPN, Personal Firewall
https://www.orchid.com/
GNU Affero General Public License v3.0
649 stars 103 forks source link

Export buttons don't work on Android #94

Closed wyphan closed 2 years ago

wyphan commented 3 years ago

Describe the bug On the Android app, the buttons to copy or download the exported account don't work.

To Reproduce Steps to reproduce the behavior:

  1. Use the default user interface (not the Multi-hop UI)
  2. Tap "Manage Accounts"
  3. Tap the cog wheel next to the Orchid Address gravatar image
  4. Tap "Export"
  5. Tap either the "Copy" button or the download icon
  6. See error

Expected behavior Both the copy and download buttons work to save the exported config.

Screenshots (Note: I blurred the QR code displayed on the screenshot for security reasons) Screenshot_20210608-092642

Device information:

Additional context Can somebody with an iPhone try to check if this problem also exists in the iOS version?

wyphan commented 3 years ago

After further investigation, looks like the "Copy" button works. The problem then is that the Orchid app doesn't give any feedback to the user so it's impossible to know whether it was successfully copied or not. Maybe implement some kind of toast notification? The download icon button still doesn't work.

saurik commented 2 years ago

The copy feedback was added in 58dfd3e4bfdbf49d64367f184ac499f0dc4f0c34 (which will be in the next release) and the download button was removed in 528e1ac36b4d731fb325e46da84746ef6d9a05bd (which will be in the release following that); thanks!! ;P