search

Orcomp / NPerfRunner

A performance runner for NPerf
7 stars 5 forks source link

NPerfRunner duplicates loaded tested types for a fixture #11

Open ovidiomanteiga opened 11 years ago

ovidiomanteiga commented 11 years ago

Steps to reproduce the bug (using NPerf.Fixture.IList):

  1. Launch NPerfRunner WPF application.
  2. Load C5.dll (nothing yet at the tree panel).
  3. Load NPerf.Fixture.IList.dll (it loads 1 type from it and 6 types from C5). Still OK.
  4. Load mscorlib.dll (it loads 4 types from it and duplicates the previously loaded types). Everything works well, but it must not duplicate already loaded types.
ovidiomanteiga commented 11 years ago

This bug is partially fixed by https://github.com/ovidiomanteiga/NPerfRunner/commit/5e0ee33f98815a7bdb68e06fc14376cacc368841

After creating the PerfLab instance and assign it, commonData.Lab was not null, so the assembly was added twice.

It still duplicates previously loaded types after loading new assemblies.

ovidiomanteiga commented 11 years ago

This bug is finally fixed with this change in NPerf https://github.com/ovidiomanteiga/NPerf/commit/d0ba4ad4c2bfe39224ed59c819770fe60a68cfdd. See comments there.

Now all the tests are loaded correctly, without duplicates.