Orcpub / orcpub

Code for Dungeon Master's Vault Community Edition
https://www.dungeonmastersvault.com/
Eclipse Public License 2.0
212 stars 106 forks source link

Combat Tracker / Party editing causes logout #338

Open BillyKings173 opened 4 years ago

BillyKings173 commented 4 years ago

Describe the bug After putting character sheets created by another user into a party, using the combat tracker or browsing the sheet in the party tab causes a logout of DMV. Any time a change is made to the sheet, such as casting a spell, a logout is forced.

To Reproduce Steps to reproduce the behavior:

--First have a user share a sheet via web link--

  1. When viewing character, select add to party
  2. Create a party or add the character to an existing party

--Then---

  1. View/Edit in the 'Parties' tab under 'Characters'
  2. Select the character in your party
  3. Edit a field on the character (change armor, weapon, cast a spell)
  4. In a few moments, get logged out forcibly

--Or--

  1. Go to 'Combat tracker' under 'Encounters' tab
  2. Add a party to the combat
  3. Select the character in your party
  4. Edit a field on the character (change armor, weapon, cast a spell)
  5. In a few moments, get logged out forcibly

Expected behavior Expected to run a combat and monitor spells, health, armor, weapons, and features.

Desktop (please complete the following information):

Additional context I'm attempting to run combats with a party of three, sometimes four, characters made by friends. The tool seems great, and every time I make a change it is saved when I log back in. I'd just like to stay logged in! Thanks for your attention!

DivertedCircle commented 4 years ago

Can confirm, I've run into this as well.

datdamnzotz commented 4 years ago

Yup, Currently you can not edit characters from other accounts because you are not an owner of that character. You can only edit characters that are under your logged into account.

So not really a bug, but a feature enhancement to request/grant access to other accounts/characters to edit them.

Characters you own, can be part of the combat tracker and encounters without any problems.