Orcpub / orcpub

Code for Dungeon Master's Vault Community Edition
https://www.dungeonmastersvault.com/
Eclipse Public License 2.0
212 stars 106 forks source link

Compact roll buttons #427

Closed Pireax closed 4 years ago

Pireax commented 4 years ago

Motivation / Use Case The roll buttons are a nice addition but they take up a lot of space, I think it would be better to combine the roll button and the modifier for the roll into one to make it a bit more compact.

Below some quick mockups of how this could look: image image

As some mentioned, the damage is already in the details section making it a bit redundant, below an alternative with this fixed: image

codeGlaze commented 4 years ago

I like that. But it does make the use more opaque.

There's a significant chance most, or at least... Many, users won't notice those are actual buttons.

Thoughts?

Pireax commented 4 years ago

I think that it is clear that they are buttons as the same button design is used for a lot of other actions on the website, the buttons would also still have tooltips so even if they don't notice that these are buttons they can discover it this way. (This same design is also applied in dndbeyond and worldanvil character sheets btw)

codeGlaze commented 4 years ago

This same design is also applied in dndbeyond and worldanvil character sheets btw

This actually puts me at ease with the decision. Looks like there might be room to add a tiny d20 icon or something> But, all told, I definitely agree with the idea.

datdamnzotz commented 4 years ago

On the fence about this one. I'll toss it at the patrons and have them vote 👍 👎 on it.

Open for 7 days

Butterfly-Dragon commented 4 years ago

works for me!

leoherzog commented 4 years ago

I like the idea of the d20 icon. 🎲+2 or 2🎲+4 (substituting appropriate icons) would look sharp, and meaningful iconography where space is constrained is a common design practice.

LumaDevelopment commented 4 years ago

I love the idea of the mockup posted by the original author.

The issue is finding a way to implement a dice symbol appropriate for the roll being made without morphing the size of the buttons. Perhaps we should just stick with the mock-up that started the issue as it is compact and clear. Smaller symbols might be hard to read and confusing for new players, especially if this theology is adapted in areas where the plaintext formula isn't listed.

datdamnzotz commented 4 years ago

I think the question is how we do it so it is most clear : ] Gotta think of the newbies and the seasoned vets. and getting it to work on mobile as well - and color challenged people.

jrjohnson commented 4 years ago

New player here, I spent a lot of time trying to figure out what hitting the existing buttons would do and if it aligned with what our DM wanted us to roll. This seems like a good addition to make it clear what exactly is being used to roll.

barefootcoder commented 4 years ago

Perhaps the graphic for the button itself could be shaped like a d20. That would make it pretty obvious, and then just having "+4" or what-have-you would be plenty sufficient.

datdamnzotz commented 4 years ago

Poll Results image

datdamnzotz commented 4 years ago

Resolved via #436