Orcpub / orcpub

Code for Dungeon Master's Vault Community Edition
https://www.dungeonmastersvault.com/
Eclipse Public License 2.0
211 stars 106 forks source link

[WIP] Homebrew options improvements #497

Open MeanderingCode opened 3 years ago

MeanderingCode commented 3 years ago

Description:

This PR is a WIP for the items listed below. Currently, the options appear on the builder pages and save to the homebrew object, but do not appear to be read correctly in the character builder / viewers. If someone with more familiarity can point me in the right direction (data model issues, something new not added to a reader / renderer?), it would expedite me finishing this. Otherwise, I will poke around more when I have time.

Adds some simple features and changes to some homebrew builder types:

Related issue (if applicable): Addresses #50 (not complete) Addresses https://github.com/Orcpub/orcpub/issues/172#issuecomment-627647588

Checklist:

datdamnzotz commented 3 years ago

https://github.com/Orcpub/orcpub/pull/497/checks?check_run_id=1579168521

Need to move (defn feat-builder [] under option-spells (around line 5772) so option-spells is defined. Then it works just fine. Some reason I can't push to your branch otherwise you'd have the fix

image

MeanderingCode commented 3 years ago

Need to move (defn feat-builder [] under option-spells (around line 5772) so option-spells is defined. Then it works just fine.

Thanks, @datdamnzotz. For some reason, I am able to see the section in the view just fine, anyway.

But either way, it does not apply the spells in the Feat to my character, they way the same options in the Subrace Builder do.

Also, any idea why the Weapon Proficiency I added to the Background Builder similarly doesn't apply?