Fixes #508 wand of the war mage missing bonuses

[codeGlaze]

Description:

Related issue (if applicable): fixes #508 Wand of the War Mage was not applying the spell attack modifier.

WARNING: breaks existing name keys for the various Wands of the War Mage

• Introduce new generic function for creating items (focused on caster bonuses but could be generic)

• Added some missing "action" blurbs

• Fixes possible typo in from-internal-item properties

• Automatic EOL changes to fit file format

Checklist:

• [x] The code change is tested and works locally.
• [x] I have commented my code, particularly in hard-to-understand areas
• There is commented out code in this PR. Features to return to or tweak, primarily documentation related.
• [x] My changes generate no new warnings (check the console)

[codeGlaze]

That's exactly what I did.

I used those modifiers, just abstracted it to cut down boilerplate code and potentially reuse for other items/custom items in the future.

[datdamnzotz]

That's exactly what I did.

I used those modifiers, just abstracted it to cut down boilerplate code and potentially reuse for other items/custom items in the future.

Looks like this is moving away from the convention that is already in place across all the magic items for three items. This is really the data set for all magic items, they should follow the same syntax across all of them docha think?

I disagree with what he did with the horn-of-valhalla or figurine-of-wondrous-power if you search those items they are defined by a function. There are a few of those. They really should just be typed out like the rest instead of pushing functions for them.

I'm not apposed to introducing something like this - but imho it is the data set, probably should just follow that architecture - now if you want to update them all that's fine, but let's not just do 3.

[datdamnzotz]

In https://dev.dungeonmastersvault.com for testing