Fixed Dueling style not applying +2 bonus to one handed melee weapons.
Properly checks for weapons in only one hand
Properly only applies to non-two handed melee weapons
Added ?damage-bonus-fns to damage modifier calculation
Commented out melee- and ranged- specific damage bonus methods. Weird front end issues occurred when apply was... applied to those maps plus the map for the generic damage-bonus-fns
Properly utilizing the passed functions and conditions should eliminate the need for those other two methods.
Fixed Bracers of Archery applying attack bonus instead of damage bonus
Added new method weapon-damage-bonus-mod which duplicates almost all the code from weapon-attack-bonus-mod. Combining them may be worthwhile, using a third parameter to set which bonus we want, or even both.
Added boolean method bow? for checking if (long|short) bow, basically. Matches other weapon boolean checks.
Incidental EOL change in weapons.cljc to LF
Checklist:
[x] The code change is tested and works locally.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation if necessary
[ ] There is no commented out code in this PR.
[x] My changes generate no new warnings (check the console)
Description:
Fixes Issue #249, Fixes #513; Fixes #514; Fixes #515;
Fixed Dueling style not applying +2 bonus to one handed melee weapons.
Added
?damage-bonus-fns
to damage modifier calculationCommented out
melee-
andranged-
specific damage bonus methods. Weird front end issues occurred whenapply
was... applied to those maps plus the map for the genericdamage-bonus-fns
Fixed Bracers of Archery applying attack bonus instead of damage bonus
weapon-damage-bonus-mod
which duplicates almost all the code fromweapon-attack-bonus-mod
. Combining them may be worthwhile, using a third parameter to set which bonus we want, or even both.Added boolean method
bow?
for checking if (long|short) bow, basically. Matches other weapon boolean checks.Incidental EOL change in
weapons.cljc
to LFChecklist: