Added Saga CS (#532) - Githubissues

Orcpub / orcpub

Code for Dungeon Master's Vault Community Edition

https://www.dungeonmastersvault.com/

Eclipse Public License 2.0

210 stars 105 forks source link

Added Saga CS (#532) #533

Closed Jessomadic closed 5 months ago

Jessomadic commented 3 years ago

Description:

Related issue (if applicable): fixes #532

Checklist:

[x] The code change is tested and works locally.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation if necessary
[x] There is no commented out code in this PR.
[x] My changes generate no new warnings (check the console)

datdamnzotz commented 1 year ago

I think that works. @Jessomadic @codeGlaze review?

Here are the pdfs produced

character original.pdf character original varent.pdf character icewind.pdf character cthulhu.pdf

Jessomadic commented 1 year ago

Looks good. 2 things that I would test still for it would be a Char with Spells to make sure the spell sheets and cards get added on correctly and I would put at least 1 number for each type of money to just make sure the fields populate correctly. @datdamnzotz

datdamnzotz commented 5 months ago

Closing in favor of pull request #609