search

Orcpub / orcpub

Code for Dungeon Master's Vault Community Edition
https://www.dungeonmastersvault.com/
Eclipse Public License 2.0
210 stars 105 forks source link

Are the notes supposed to be printable? #555

Open lafranst opened 2 years ago

lafranst commented 2 years ago

Describe the bug In the GUI, the notes always show after the description. But they are nowhere to be seen on the PDF. Is this a bug or a feature?

To Reproduce

Steps to reproduce the behavior:

  1. Create a character sheet.
  2. Below the description, there is a Notes field. Enter information in there.
  3. Save
  4. Print the PDF.

Expected behavior

Since there is a Notes field, I would expect for those to be printed.

In the GUI: image

Here is the PDF. Note that I manually added the notes in the Features and Traits section directly in the PDF, not through the GUI. But this is something I need to do every single time I generate the PDF. Which is really annoying.

StephaneLafrance - Bobo Featherbottom Level 1.pdf

Desktop (please complete the following information):

datdamnzotz commented 2 years ago

Currently it does not. Could be added pretty easy to here: https://github.com/Orcpub/orcpub/blob/5506ba1a0fa949c74a7bda59335e95a4b6edbd9f/src/cljc/orcpub/pdf_spec.cljc#L137

Issue is going to be space for all the text for characters at higher levels with all the features/traits etc. Might have to implement some logic where another notes page spills over.

Jessomadic commented 2 years ago

I think the best way to handle this is to replace the "Character Backstory" section with the notes section and have it just print there instead seeing as if you are printing it out it's a huge waste of ink to print out your backstory everytime and the notes are much more useful