Orcpub / orcpub

Code for Dungeon Master's Vault Community Edition
https://www.dungeonmastersvault.com/
Eclipse Public License 2.0
210 stars 105 forks source link

Custom Item and Proficiency issue #560

Open lafranst opened 2 years ago

lafranst commented 2 years ago

Describe the bug My goal was to create a halfling-friendly quarterstaff, something similar to a Japanese Jo. I found that I could do this via the Item Builder.

In the attached screenshots, you will see that I created: 1- A custom item: That's the only way I could access the "Versatile" weapon attribute. 2- I updated the damage die for both standard and versatile damage. 3- I made the weapon a simple melee weapon with bludgeoning damage.

Issues: 1- Even though it was a simple weapon for proficiency purposes, it was not considered as such. A Rogue is proficient with all Simple Weapons, and should have been noted as such. See screen shot where you see the red X in the proficiency column. 2- The normal damage, a d4, is showing as "d" in the GUI (See screenshot again). 3- I did NOT define the weapon as "Finesse". My character's strength is 10 (+0) and dexterity is 17 (+3). and therefore the attack bonus. The GUI is showing +3 attack and damage for the weapon, as if it was a "Finesse" weapon. 4- The PDF did not show that weapon at all.

Expected behavior

1- If defining a new Item as a weapon of the "Simple Weapon" group, classes that have access to all Simple Weapons should automatically be proficient with that new weapon. 2- The GUI should show the proper die for the weapon damage. 3- This was a melee weapon. By default, melee weapon bonuses are based on Strength, unless they have the "Finesse" attribute. AS this was not defined as a "Finesse" weapon, we should have seen the Strength bonus (+0) being used here instead of the Dex bonus (+3). 4- The overall expected behavior for the GUI should have been to show a +2 on attack for proficiency, and +0 on damage for strength, with a d4 (not just "d") for normal damage and d6 for versatile damage. 5- The PDF should have shown the new weapon item in the weapon list.

Screenshots

PDF: StephaneLafrance - Bobo Featherbottom Level 1.pdf

Item Builder: Bug Damage Die 2

GUI: Bug Damage Die 1

Desktop (please complete the following information):

datdamnzotz commented 2 years ago

As seen in #35