Orcpub / orcpub

Code for Dungeon Master's Vault Community Edition
https://www.dungeonmastersvault.com/
Eclipse Public License 2.0
208 stars 104 forks source link

Support loading jars from local `./lib` dir #583

Closed johntyree closed 1 year ago

johntyree commented 1 year ago

Description:

pdfbox and its deps aren't available upstream anymore, but we include them directly in the ./lib dir, presumably so that people can copy them into ~/.m2 themselves and get things working. This makes onboarding extremely confusing for losers like myself that don't know anything about clojure or leiningen or are jvm novices in general.

This changes teaches lein to use ./lib as a local repo and use the jars it finds there, ignoring any checksum related issues since we don't have checksums for these and it's very unlikely that they get corrupted while being copied locally anyway.

Related issue (if applicable): fixes #539

Checklist:

codeGlaze commented 1 year ago

Thoughts on why the linter is having a heart attack on this?

johntyree commented 1 year ago

@codeGlaze see #584. Looks like it was probably broken for awhile? At least as long as the pdfbox dep was unresolved.

codeGlaze commented 1 year ago

Merging this to create a chain for reverting if necessary, as mentioned on discord.