search

OrderN / CONQUEST-release

Full public release of large scale and linear scaling DFT code CONQUEST
http://www.order-n.org/
MIT License
96 stars 25 forks source link

Version Control system.make for different machines #272

Closed ilectra closed 7 months ago

ilectra commented 7 months ago

Fixes #247

tkoskela commented 7 months ago

It seems that the GitHub actions runners give you a hostname that looks difficult to predict. 

Running on SYSTEM .2dmmb0nmsnvutc1liyrbff0gyd, using makefile system/system.2dmmb0nmsnvutc1liyrbff0gyd.make

Maybe we could check for a plain system.make if the hostname'd one is not found? (or possibly check for it first)

ilectra commented 7 months ago

It seems that the GitHub actions runners give you a hostname that looks difficult to predict.

Running on SYSTEM .2dmmb0nmsnvutc1liyrbff0gyd, using makefile system/system.2dmmb0nmsnvutc1liyrbff0gyd.make

Maybe we could check for a plain system.make if the hostname'd one is not found? (or possibly check for it first)

I made the gha.make be copied to the correct system.xxxxx.make. But what you suggest also makes sense.... Could do either.

ilectra commented 7 months ago

I think this is ready, unless you want to add your system.thomas.make file @tkoskela

Oops, no, I forgot to add documentation. Will finalise tomorrow.

ilectra commented 7 months ago

@tkoskela done, please review!

ilectra commented 7 months ago

@tkoskela this should be ready for re-review/merging.