OrderOfTheBee / alfresco-pdf-toolkit

66 stars 58 forks source link

Fix dependencies to avoid fat AMP and move test class into src/test/java #40

Closed AFaust closed 6 years ago

AFaust commented 6 years ago

Fixes #39

This PR corrects the dependency management section of the Repository-tier POM to only include those JARs that are actually needed for distribution. By moving the single test class in the appropriate path all other JARs could be included only for the test scope. Some dependencies / dependency details have been removed since they are already provided / loaded transitively by the Alfresco artifacts and/or parent POM.

Note: The unit test currently fails because the Alfresco class "org.alfresco.web.app.ResourceBundleBootstrap" is not available in a JUnit context. This would be easily fixable if Alfresco provided proper artifacts, but after trying to include org.alfresco:alfresco:classes:jar and org.alfresco:alfresco-remote-api:jar (since the former classes JAR does not include this as transitive dependency), it still does not work because some config from org.alfresco:alfresco-share-services is referenced that is not included, despite org.alfresco:alfresco-share-services being a dependency of org.alfresco:alfresco My assumption is that the extra message bootstrap could simply be removed. There should be no necessity to bootstrap messages via a web-client class when they have already been bootstrapped via a core class.