search

OrderOfTheBee / alfresco-pdf-toolkit

66 stars 58 forks source link

PDF- ToolKIT 6.2 upgrade #64

Open Madushani opened 4 years ago

douglascrp commented 4 years ago

Hello.

Thanks for taking the time to work on this, but I have to ask... Have you tried the latest code version before doing the upgrade by yourself? As you can see in https://github.com/OrderOfTheBee/alfresco-pdf-toolkit/pull/55, the code has already been changed to work with Alfresco 6.x, so I believe you should be trying it and check it there is any kind of incompatibility with the version 6.2.

Besides that, I see you have created a really big PR, with so much changes (basically replacing all the existing code), that it seem really really hard to understand what has been changed.

Can you review that?

Madushani commented 4 years ago

Hello douglascrp,

Sorry for the confusion. I have made a new pull request. It contains the destination folder UI change

nachopants commented 4 years ago

I can confirm the latest release does not work with v6.2 community, or the latest ECM enterprise.

Tried installing on both with fresh deployments and no other plugins.