search

Orderella / PopupDialog

A simple, customizable popup dialog for iOS written in Swift. Replaces UIAlertController alert style.
http://www.mwfire.de
Other
3.96k stars 522 forks source link

PanGestureDismissal calls viewWillAppear #288

Closed nflows closed 5 years ago

nflows commented 6 years ago

Hi Orderella I'm using this awesome library for a while now and i run into some struggles.

If you init a PopupDialog with a custom viewcontroller and you don't set the panGestureDismissal property to false, then the presented PopupDialog calls the viewWillAppear method on each swipe/pan gesture. So if you call that property "panGestureDismissal" it should dismiss that one not only call viewWillAppear or do i misunterstand something here?

It is getting very strange and confusing if you are implementing a TableView. The rows / cells editing methods are not called properly - because the viewWillAppear blocks the process.

mwfire commented 6 years ago

Hey there! Thanks for the heads up, I will check as soon as possible. Thx!

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

mwfire commented 5 years ago

Sry, reopening this as it is still valid.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.