search

Orderella / PopupDialog

A simple, customizable popup dialog for iOS written in Swift. Replaces UIAlertController alert style.
http://www.mwfire.de
Other
3.96k stars 522 forks source link

Use Image Cache from kingfisher or link #296

Closed ghost closed 5 years ago

ghost commented 6 years ago

This is more of a good enhancement for future release,

We can only pass a UIImage to PopupDialog, but it will be great if we can pass the link of the image and use the cache function like kingfisher. It takes a little time to open the popup when the internet is slow.

Thank you for keeping up this repo its great

valterh4ck3r commented 5 years ago

Waiting...

mwfire commented 5 years ago

Hey there. For async loading, I would suggest to create a custom view controller. There are a lot of popular image loading/caching libraries out there, so with a custom VC you can use the library of your choice. We try to keep PopupDialog as lightweight as possible, which also means not introducing additional dependencies if it can be avoided. Hope that makes sense :)

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.