search

Orderella / PopupDialog

A simple, customizable popup dialog for iOS written in Swift. Replaces UIAlertController alert style.
http://www.mwfire.de
Other
3.96k stars 522 forks source link

Swift 4 Support/Compatibilty #298

Closed AlexGZC closed 5 years ago

AlexGZC commented 5 years ago

Hi, I would like to be supported, I am still working with Swift 4, however, when I install it throught Cocoapod i get a lot of issues:

Please help me, i love this pod. I am such in rush in order to use it

rob8861 commented 5 years ago

@AlexGZC please do the following to get swift 4.0 support

open up your Podfile and replace the line for popupdialog with this one

pod 'PopupDialog', :git => 'https://github.com/Orderella/PopupDialog.git', :tag => '0.8.1'

then recompile and it should work.

mwfire commented 5 years ago

Hey there!

As @rob8861 suggests. Please check out the release section to see when new versions are introduced, so you can pick the version before. To ensure backward compatibility, I usually do version increments when supporting a new Swift version. You can specify a specific version in your Podfile like

pod 'PopupDialog', '~> 0.8'

However, you should be able to use the latest PopupDialog and mix versions in your project. Afaik CocoaPods assumes the same for all libraries by default. See https://github.com/CocoaPods/CocoaPods/issues/8118 for a post-install action that allows for different Swift versions per library.

Hope that helps.

carlosvalenzuela0193 commented 5 years ago

i have problems with swift 4.2 it throws me several errors

ardee19 commented 5 years ago

i have problems with swift 4.2 it throws me several errors

Are your errors something with the NSNotification?

Ex. 'orientationDidChangeNotification' has been renamed to 'NSNotification.Name.UIDeviceOrientationDidChange'

carlosvalenzuela0193 commented 5 years ago

i have problems with swift 4.2 it throws me several errors

Are your errors something with the NSNotification?

Ex. 'orientationDidChangeNotification' has been renamed to 'NSNotification.Name.UIDeviceOrientationDidChange'

I don't remember I decide not to use this framework because it throws to many errors

mwfire commented 5 years ago

Hey there,

this library is Swift 4.2 compatible. Please make sure your parent project was fully migrated to Swift 4.2 and run pod install again. More information can be found here: https://swift.org/migration-guide-swift4.2/

Moreover, you can check out the example project, which is Swift 4.2 as well. @carlosvalenzuela0193 Can you confirm the example project works for you?

Thx, all!

arealdeadone commented 5 years ago

Hey there,

this library is Swift 4.2 compatible. Please make sure your parent project was fully migrated to Swift 4.2 and run pod install again. More information can be found here: https://swift.org/migration-guide-swift4.2/

Moreover, you can check out the example project, which is Swift 4.2 as well. @carlosvalenzuela0193 Can you confirm the example project works for you?

Thx, all!

The project worked after renaming and refactoring several lines of code according to the compiler. My parent project was fully migrated to Swift 4.2.

mwfire commented 5 years ago

Hey there! Please check out version 1.0.0. Looking forward to your feedback.

mwfire commented 5 years ago

Closing this as of related feedback after release of 1.0.0