search

Orderella / PopupDialog

A simple, customizable popup dialog for iOS written in Swift. Replaces UIAlertController alert style.
http://www.mwfire.de
Other
3.96k stars 522 forks source link

Swift 5 update #309

Closed Maryom closed 5 years ago

Maryom commented 5 years ago

Thanks for this awesome repo. 👌🏼

mwfire commented 5 years ago

Hey there! Thanks a lot for your contribution. Please make sure to work on the Swift 5 branch, please: https://github.com/Orderella/PopupDialog/tree/Swift5

Otherwise we will duplicate our efforts ;)

Thanks a lot!

Maryom commented 5 years ago

OMG! I didn't notice that there is a Swift 5 branch 🤦‍♀️

Thank you.

mwfire commented 5 years ago

No problem, thank you! I am basically currently struggling with getting Travis CI to run. It does not recognize the device identifier, so prewarming the simulator fails. The real tests, however, pass. I am thinking of removing the failing command for testing purposes :) It's kinda trial and error ;)

Maryom commented 5 years ago

@Mazyod has an awesome experience in this 👍🏼

mwfire commented 5 years ago

Ok, just commented out the prewarming. One thing I noticed is that apparently, simulators now seem to have different names with iOS 12.2. Like iPhone Xʀ vs. iPhone XR.

@Mazyod has an awesome experience in this 👍🏼

If Travis builds keep failing, I might indeed need some advice :)

Maryom commented 5 years ago

@mwfire I can't install it I got:

[!] CocoaPods could not find compatible versions for pod "PopupDialog":
  In Podfile:
    PopupDialog (~> 1.1)
mwfire commented 5 years ago

Nope, it's not yet published, as of the failing CI builds. I will merge as soon as I have fixed it (today). Until then you will have to specify the branch in your pod file. :(

Maryom commented 5 years ago

Ok thanks.

mwfire commented 5 years ago

@Maryom Ok, 1.1.0 is available now!

Maryom commented 5 years ago

Great :) thank you.