search

Orderella / PopupDialog

A simple, customizable popup dialog for iOS written in Swift. Replaces UIAlertController alert style.
http://www.mwfire.de
Other
3.96k stars 522 forks source link

Portrait only #311

Closed jonas-sleepcycle closed 5 years ago

jonas-sleepcycle commented 5 years ago

Is it possible to enable portrait only mode when showing a dialog?

I do not want to use a global extension to override supportedInterfaceOrientations as it's a bad practice to do this and I may need landscape support in the future. Could this be a parameter on PopupDialog?

mwfire commented 5 years ago

Hi @jonas-sleepcycle, sorry for my late reply, I will check on this asap.

pontusm commented 5 years ago

I made a simple fix in my fork: https://github.com/pontusm/PopupDialog/commit/2a3cf010a05b9e2e483f9b26f36be29de448d4eb

mwfire commented 5 years ago

Thanks, and sorry again for my late reply. I will check out your fork, @pontusm

pontusm commented 5 years ago

Thanks, I also added support for action sheet style similar to UIAlertController and a few other improvements. Maybe we can merge this into the main fork somehow. 🤔

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.