search

Orderella / PopupDialog

A simple, customizable popup dialog for iOS written in Swift. Replaces UIAlertController alert style.
http://www.mwfire.de
Other
3.96k stars 522 forks source link

Message becomes too long and the view doesn't allow scrolling to keep the popup within a certain size #325

Closed tcheek-bw closed 5 years ago

tcheek-bw commented 5 years ago

Please fill out this template when filing an issue. All ℹ symbols should be replaced with information on the issue. Please remove this line and all above before submitting.

Report

Environment

Please provide information on your development environment, so we can build with the same scenario.

Dependency management

If you are not using any dependency managers, you can remove this section.

What did you do?

Created a popup with a long message text.

What did you expect to happen?

The view would limit itself to a margin of the screen height and turn the message subview/container view into a scroll view so that the message could scroll and not push the popup to be too long.

What happened instead?

Popup ended up being too long for the screen size. I'm trying to create an info popup with important information and I can't really remove any of it to make it shorter :/

Project that demonstrates the issue

github.com/Hoid/FCS_Mock_Season_Creator

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Hoid commented 5 years ago

Bump, still an issue

adeiry commented 5 years ago

@Hoid I have the same issue!! did you find a solution?

tcheek-bw commented 5 years ago

No, unfortunately :(

mwfire commented 5 years ago

Hey there! I will be looking into this. This was not yet implemented as there was no clear requirements ;) This can be achieved right now by using a custom view controller, which gives you more fine grained control.

However, as far as it concerns the default dialog: I would suggest making only the message scrollable. It will not solve all of the issues but multiline messages should be handled like this. This would also require defining a max height. I guess it would make sense to do this internally by calculating the screen/dialog size ratio. What do you think?

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.