Orderella / PopupDialog

A simple, customizable popup dialog for iOS written in Swift. Replaces UIAlertController alert style.
http://www.mwfire.de
Other
3.96k stars 522 forks source link

s.swift_version should be '5.0' not '5' #326

Closed jimduchek closed 5 years ago

jimduchek commented 5 years ago

224 Report

Latest version of Xcode does not consider '5' to be >= '5.0', I guess? so it pops a warning that 'conversion to swift 5 is available'. Changing s.swift_version to '5.0' fixes as CocoaPods directly copies that value to SWIFT_VERSION in the xc project.

Environment

Please provide information on your development environment, so we can build with the same scenario.

Dependency management

If you are not using any dependency managers, you can remove this section.

What did you do?

Used this pod

What did you expect to happen?

Not get a 'transition to swift 5' warning for PopupDialog

What happened instead?

got a 'transition to swift 5' warning for PopupDialog

Project that demonstrates the issue

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.