Transitions don't use "inDuration"

[BlueCobold]

224 Report

All transitions use hardcoded "inDuration" of 0.6s, although they have a constructor-parameter for it. It would further be great to have them flexible, because 0.6s is really slow for some situations and animations.

Environment

• Xcode version (e.g. 9.1): 12.1
• PopupDialog version (e.g. 0.5.0): 1.1.1
• Minimum deployment target (e.g. 9.0): 13
• Language (Objective-C / Swift): Swift
• In case of Swift - Version (e.g. 4): 5

Dependency management

• Dependency manager (e.g. CocoaPods): CocoaPods
• Version (e.g. 1.3.1): 1.10.0

What did you expect to happen?

I expect to use animations to use the given constructor-parameters for animation durations or potentially be configurable

What happened instead?

They use 0.6s hardcoded in any case https://github.com/Orderella/PopupDialog/blob/014f7b2fe3e907c5c0cd20780eb91f458fc7655d/PopupDialog/Classes/TransitionAnimations.swift#L89 https://github.com/Orderella/PopupDialog/blob/014f7b2fe3e907c5c0cd20780eb91f458fc7655d/PopupDialog/Classes/TransitionAnimations.swift#L120 https://github.com/Orderella/PopupDialog/blob/014f7b2fe3e907c5c0cd20780eb91f458fc7655d/PopupDialog/Classes/TransitionAnimations.swift#L151

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.