search

Ordinastie / MalisisCore

MIT License
28 stars 35 forks source link

Special Characters problem on windows with shipped SpongePowered ASM #148

Open NitroxydeX opened 6 years ago

NitroxydeX commented 6 years ago

It seems like the shipped SpongePowered ASM has some problems with special characters like "!" and "?" in folder-names on windows. Resulting into a

org.spongepowered.asm.service.IMixinServiceBootstrap: Error reading configuration file because it can't find the correct folder. It searches for a folder without that special characters.

Ordinastie commented 6 years ago

The '?' character is not a legal character in windows path, but there is no problem with '!'. In any case, I'm not sure why you post the issue here, it should probably belong there.

NitroxydeX commented 6 years ago

I've reported it here because your mod shipped it - stated by the log. And it had problems with "!" because the folder-path it used was displayed without it - resulting into a file not found error.

Barteks2x commented 6 years ago

NTFS supports all characters except \0 and /, it's windows itself that doesn't really support ?. It's also a valid character inside filenames in zip files (and jar files are zip files).

! causes an issue because of this: http://bugs.sun.com/view_bug.do?bug_id=4523159

NitroxydeX commented 6 years ago

@Barteks2x that's a really old bug with the !. Well. Since I've already fixed it by removing the ! from the path-name there seems to be no fix at all for this problem.

This might be closed or let open until it is fixed by java itself.