search

OreCruncher / BetterRain

Based on the BetterRain mod from Wirsbo
20 stars 13 forks source link

[1.8.9-1.1.0.2ALPHA] Incompatibility with Thaumcraft's shaders. #12

Closed MrGraphic closed 6 years ago

MrGraphic commented 8 years ago

I noticed some small issues when TC's shaders kick in. The first one happens when TC changes fog whan player is close to Eldritch Guadian de_fog and second when player's vision changes under Unnatural Hunger potion effect: hunger

OreCruncher commented 8 years ago

I think what is happening here is that BetterRain and Thaumcraft is fighting over the fog in Minecraft. Left hand doesn't know what the right hand is doing. Both of the things you mention are all part of Minecraft's fog rendering. I need to check into whether I can detect these conditions and not take over. My preference is to let other mods do their custom fog processing without stepping on them.

MrGraphic commented 8 years ago

My exact thought. Btw thank you for taking over this small but fantastic mod not to mention your expansion. Thanks :).

OreCruncher commented 8 years ago

Azanor/thaumcraft-5#233

OreCruncher commented 8 years ago

A follow up. I made changes to fog rendering since this issue came up, and I was wondering if you had a chance to see whether those changes made a positive impact on Thaum fog behavior.

OreCruncher commented 6 years ago

I am backporting fog effects from 1.10.x+ branches and it should address this issue.

OreCruncher commented 6 years ago

Fixes for compat should be in v1.0.6.1 along with other fog tweaks.