[1.8.9] Crash with SpongeForge (Dynamic Surroundings)

[ajthemacboy]

SpongeForge issue link: https://forums.spongepowered.org/t/spongeforge-crash-on-ftb-unstable-with-forge-1732/

Server log: https://gist.github.com/ajthemacboy/fa08dfdd69014249f5f3

SpongeForge: Latest version, Forge: 1732

[OreCruncher]

Looks like Sponge is wanting to do something with updateWeatherBody() as well which leads to a conflict. Transform hook can be found here.

Need feedback from the Sponge crew to figure out the best way to resolve without gutting a Dynamic Surroundings feature.

[OreCruncher]

Seems like two possible solutions:

• Rewrite to use mixins. Not sure if mixins are supported on Forge w/o Sponge.
• Change the transformed to insert the hook and return at the top of the method without wiping it out.

Because of the nature of the change I will delay until the next release cycle (*.0.5.x). Trying to get this cycle completed and to RELEASE.

EDIT: So I don't forget - https://forums.spongepowered.org/t/spongeforge-crash-on-ftb-unstable-with-forge-1732/11382/7

[OreCruncher]

Did a quick fix to get it working. Will take on mixin conversion in a separate task.

[OreCruncher]

Release version pushed to CurseForge that should be compatible with SpongeForge