OreCruncher / DynamicSurroundings

Dynamic Surroundings mod for Minecraft 1.10.x+
MIT License
120 stars 35 forks source link

Ztones Lamp Color issue after update #293

Open Kortako opened 6 years ago

Kortako commented 6 years ago

Mod Version: 1.7.10-1.0.6.1 Forge Version: 1.7.10-10.13.4.1614

Link to crash log (if applicable):

Description: This is kind of weird, but after updating from 1.0.6.0 to 1.0.6.1, Ztones Flat Lamps (the lit, white version) turn dark grey-ish during the night cycle...sometimes. Some nights it's fine. And if you sleep and turn it day, they go back to being white. It's really noticeable when it happens, because my base is covered in them. This never happened in 1.0.6.0, and the only mod I updated was this one (to fix the IC2 sound bug).

I know that isn't much to go on, but I'll try to get some screenshots if I see it happen again.

OreCruncher commented 6 years ago

It's fog related. I have seen this with other mods and the way they do fancy lighting. For example, the illumination globes created by the illumination wand from Better Wands has similar issues. If this is causing difficulties you can turn off morning fog - it seems to be the trigger in this particular case.

Kortako commented 6 years ago

That's what I thought, but I already turned morning fog off in the config file and it still does it.

Kortako commented 6 years ago

Here's what my config looks like, on both server and client:

fog {
    # Allow desert fog when raining [default: true]
    B:"Desert Fog"=true

    # Higher the player elevation the more haze that is experienced [default: true]
    B:"Elevation Haze"=true

    # Enable biome specific fog density and color [default: true]
    B:"Biome Fog"=true

    # Enable morning fog [default: true]
    B:"Morning Fog"=false

    # Enable morning fog [range: 1 ~ 10, default: 1]
    I:"Morning Fog Chance"=1

    # Enable morning fog [default: true]
    B:"Weather Fog"=true
}

I also have fog visually completely disabled (I use Optifine E3, I don't remember if that's also an option in vanilla).

OreCruncher commented 6 years ago

That is strange. Need a screenshot so I can take a closer look.

Kortako commented 6 years ago

Sure, I'll see if I can get one to you next time I'm on Minecraft. Is Weather Fog okay to keep enabled? I noticed it has the same comment tag as morning fog in the config, but I assume they aren't related and it's a typo?

OreCruncher commented 6 years ago

Weather fog is a separate thing but related. Internally I have several fog range calculators that determine the block ranges for fog start/end (far plane). Morning fog is one calculator, weather is another. You could get the same visual artifact with weather fog, but I think that would only occur with heavier rain fall.

(NOTE: The fog rendering is handled by OpenGL. All Minecraft/mods do is determine fog start/end distances, and perhaps the general fog render method.)

Kortako commented 6 years ago

Okay, I got some screenshots of it happening. Not sure how useful they'll be though.

Here's how it looked when it happened. My ceiling is covered in flat lamps, and this was about at "midnight" in game. They're all a pretty dark grey. 2018-03-22_23 36 56

Here's what they should look like: 2018-03-22_23 37 13

The lamps start off okay around dusk, and then progressively get greyer and greyer as the night goes on until they reach the color they were in the first picture.

Here's another example 2018-03-22_23 36 47 2018-03-22_23 37 21

Hope that helps. Tell me if there's anything else I can do to help/debug.

OreCruncher commented 6 years ago

What biome is your base in?

Kortako commented 6 years ago

It's a BoP Canyon biome

Edit: My friends are in two other biomes that it also happens in, one is a snow biome and the other is desert plains or something like that. I'm not completely sure if it happens in every biome or it's just coincidence that we're all in different biomes it happens in.