OreCruncher / DynamicSurroundings

Dynamic Surroundings mod for Minecraft 1.10.x+
MIT License
120 stars 35 forks source link

[Suggestion] config option for compatibility with swiss cheese caves on 1.12.2 #539

Open Biviho opened 4 years ago

Biviho commented 4 years ago

swiss cheese caves give you the old cave system, with the ability to have underwater caves and ravines under oceans. the problem is that dynamic surrounding will generate a lot of parcticles and a lot of "water splash" sounds in ravines and caves underwater, making the game really laggy. this could be avoided by adding the ability to disable a feature per biomes, i already searched this option, but i didn't find it, if there is already one

OreCruncher commented 4 years ago

This effect is tied to blocks not biomes so it wouldn't be possible to disable per biome. You can disable this effect entirely by setting "Enable Water Splash" to false in the config. I haven't looked at the Swiss Cheese Cave Mod, but I suspect what is happening is that during world gen a lot of air blocks get generated under water source blocks. The DS water splash routine detects these air blocks and generates a splash effect.