OreCruncher / DynamicSurroundings

Dynamic Surroundings mod for Minecraft 1.10.x+
MIT License
120 stars 35 forks source link

[1.16.5] Significant FPS drops #690

Open Omni35 opened 3 years ago

Omni35 commented 3 years ago

Mod Version: DynamicSurroundings-1.16.4-4.0.3.12

Forge Version: 36.0.40

Link to client log: https://pastebin.com/ZGgwa39m

Link to MultiMC log: https://paste.ee/p/3iSBH

Link to MultiMC Settings: https://i.imgur.com/KzFp0Lk.png

Description: There's a significant FPS drop and frequent stuttering after the mod is added, in both existing and new worlds. The RAM usage barely goes above 3GB from the allocated 8 before a GC cycle is done. My guess is that it's caused by the sound processing, if it's anything like Sound Filters was, I needed to decrease the "Number of blocks reverb will check through" from the default 1024 to 124 to avoid similar issues.

Did you just add the mod to a pack? Yes

Did it just start crashing, or has it always crashed? No crashes.

Did you update/add any other mods in your pack? Yes, although the issue doesn't appear without Dynamic Surroundings. Added mods with DS:

Updated one mod, from 1.0.0 to 1.1.0

If updating multiple mods did you update one by one or all at once? To help narrow the problem down adding one by one is helpful. All at once.

Is the modpack you are using available online somewhere? If the crash is due to mod interaction having the pack available makes things much easier. It is much harder to work these types of issues with a private kitchen sink pack containing 250 mods. It's a public pack (Odisea, version 1.1.0) but modified by me since I'm helping with issues/suggestions. Mods I added:

Mods I removed:

OreCruncher commented 3 years ago

Have you tried it with the base pack plus DS?

EDIT: Also, have you tried without OptiFine? EDIT2: Changelog for OptiFine G7 indicates it is compatible with Forge 36.0.42. Modpack installs with 36.0.40. Not sure if it is an issue. (I see that you have a preview of G8 installed.) EDIT3: I tried the base pack + OptiFine G7 and do not see any issues.

Omni35 commented 3 years ago

I've tried the base pack with OptiFine+DS and it still persists, regular fps stuttering every 4 seconds, drops even lower when I'm in the water or look down. I'm sorry but I can't check without OptiFIne since my fps is basically trash unless I disable "Terrain Animated" option with OF.

I have tried adding Sound Filters and it does remedy it a bit, but the gameplay still isn't as smooth as it was before adding DS.

I don't know if this helps with anything, but here's a screenshot of my F3 when all mods are present. https://i.imgur.com/9Vncrwx.png And one before DS was added: https://i.imgur.com/zeP1D02.png

OreCruncher commented 3 years ago

@Omni35 Try this updated JAR and let me know if there is a difference. I changed how the handshake works when connecting to a server. https://github.com/OreCruncher/DynamicSurroundings2/releases/tag/1.16.4-4.0.4.1

Omni35 commented 3 years ago

I've been testing around and the issue persists, although now it stays even after I remove DS and load an existing world (regular fps drop every 5th second, cutting my FPS in half), which doesn't happen in new worlds.

With 4.0.3.12 the issue disappears when I remove DS, and it's less frequent (every 10th second) if I add Sound FIlters.

Idk man, it might even be some interaction with OptiFine, but I can't test without it which bothers me since I'd like to help better.

OreCruncher commented 3 years ago

Based on the screenshot timing information (right side toward the bottom under the HUD info) things look normal. What you can do is enable debug logging in all 4 configs, and load up your world. Hit F3. You will see a lot more debug info displayed. If you could change your screen resolution and take a screenshot I can review the detailed info to see if I can find out. If you can, wait until you hit a lag spike and take a screenshot right after.

Omni35 commented 3 years ago

Added more just in case.

Before a spike: https://i.imgur.com/JwLcozt.jpeg After a spike: https://i.imgur.com/v2fh0Vw.jpeg After a GC: https://i.imgur.com/RmhmYap.jpg MultiMC Log: https://paste.ee/p/4JwRU

CitiesXL2815 commented 3 years ago

i'm also having same issue on 1.16.5 Frame dropping and don't have optifine installed also when i remove the mod it fixes frames and there back to normal