OreCruncher / DynamicSurroundings

Dynamic Surroundings mod for Minecraft 1.10.x+
MIT License
120 stars 35 forks source link

[1.16.4] Sunrise/Sunset fog effects visible even deep underground #708

Open AeiouEnigma opened 3 years ago

AeiouEnigma commented 3 years ago

Mod Version:

1.16.4-4.0.4.1

Forge Version:

1.16.5-36.1.3

Description:

Fog color adjusts based on time of day even while deep underground. Is it possible to adjust this mod's fog implementation such that only surface fog changes based on the time of day?

OreCruncher commented 3 years ago

How deep? There is bedrock fog which can occur near bedrock levels.

AeiouEnigma commented 3 years ago

I specifically mean that, for example, when in a cave, the morning fog effect is still visible, as deep as y=20 (the deepest sufficiently large cave I could find). I don't know how feasible it is to restrict that effect (and the weather fog) to specific elevation ranges, but if it is you should look into it.

I had bedrock fog disabled while testing this. One of the reasons why I find it takes away from the experience of using this mod is that, when morning fog occurs, a player facing eastward in a cave sees reddish-orange fog as though they're watching the sun rise, even though the sun is not even remotely visible.

Here's an example of what I mean (at around y=20, time=23000) 2021-04-07_02 53 12