OreCruncher / DynamicSurroundings

Dynamic Surroundings mod for Minecraft 1.10.x+
MIT License
120 stars 35 forks source link

[1.12.2] Startup Crash when updating Tool Progression #715

Open TheComputerizer opened 3 years ago

TheComputerizer commented 3 years ago

Mod Version:

3.6.2.1

Forge Version:

14.23.5.2854

Link to client log:

Here is the log

Link to crash log:

Here is the crash report

Description:

I updated Tool Progression from 6.10 to 6.12 and now I am getting a crash related to this mod. I posted an issue for Tool Progression because that is what I updated, but the dev is saying that the crash is caused by Dynamic Surroundings.

If you need it, here is where you can download my pack and break it by updating Tool Progression.

TheComputerizer commented 3 years ago

I should also mention that this crash occurs with or without having mixin compatibility, and I have not needed to use that mod before this either

OreCruncher commented 3 years ago

Not Dynamic Surroundings

[18:07:51] [Client thread/ERROR]: The full error
net.minecraftforge.fml.common.toposort.ModSortingException: There was a cycle detected in the input graph, sorting is not possible
A dependency cycle was detected in the input mod set so an ordering cannot be determined
The first mod in the cycle is FMLMod:crafttweaker{4.1.20}
The mod cycle involves:
    FMLMod:p455w0rdslib{2.3.161} : before: [], after: [redstoneflux, mantle, tconstruct, enderio, projecte, tesla, thaumcraft, albedo]
    FMLMod:toolprogression{1.12.2-1.6.12} : before: [tconstruct, metallurgy, aoa3, twilightforest, brandoncore, codechickenlib], after: [gamestages, orestages]

First I have seen something like this. It looks like there is a dependency inversion, where Mod A depends on Mod B which depends on Mod C which depends on Mod A. Because of this initialization will fail and will be in an inconsistent state which causes other problems for mods like DS.

TheComputerizer commented 3 years ago

I will poke the Tool Progression dev again, but thanks for the explanation