OreCruncher / DynamicSurroundings2

Minecraft mod that alters the player's sound and visual experience. For Minecraft 1.16.4+.
GNU General Public License v3.0
16 stars 7 forks source link

DynamicSurroundings-1.16.4-4.0.3.7 breaks most of the features #7

Closed Tsoccerguy3 closed 3 years ago

Tsoccerguy3 commented 3 years ago

particle effects , Aurora , sound etc,,.. are not working or not working in full . Multiplayer most features are not working . single player some are not working . Looks like everything that broke is using default vanilla

OreCruncher commented 3 years ago

Its working for me in my DW20 pack. What pack are you using? Also, can you link your latest.log? There may be an error in there that prevents processing of configurations during client connect. Speaking of - is this a single player world or are you connecting to a server?

Tsoccerguy3 commented 3 years ago

This is in Multiplayer . on a paper 1.16.5 server , testing the mod by itself , in a snowy taiga biome no breath , aurora , etc . I tested with and without the server texture pack with the same results . It may be a Java problem , Paper is starting to move to java 11 or higher . some mods are java 8 and higher . Java 16 is so much more advanced .

2021-01-29_16 31 37 2021-01-29_16 31 42

debug.log

Tsoccerguy3 commented 3 years ago

things seemed to be working on 4.0.3.5

OreCruncher commented 3 years ago

Ah - Paper. This is the second report. Paper is basically vanilla no mods right?

Tsoccerguy3 commented 3 years ago

https://github.com/PaperMC

Its a fork of spigot , tries to be more optimized , it uses the same plugins that bukkit , spigot uses

OreCruncher commented 3 years ago

Try this JAR: https://github.com/OreCruncher/DynamicSurroundings2/releases/tag/1.16.4-4.0.3.8

Tsoccerguy3 commented 3 years ago

4.0.3.8 appears to be working on Multiplayer now

Tsoccerguy3 commented 3 years ago

this update works

OreCruncher commented 3 years ago

OK. When Forge connects to a Forge server it will get two events for tag updates. When connecting to Paper it gets one. Explains some things.

OreCruncher commented 3 years ago

@Tsoccerguy3 Can you do me a favor and test out this jar? I would also like to get a copy of the latest.log from when you log in. (I am changing how connections are detected.) https://github.com/OreCruncher/DynamicSurroundings2/releases/tag/1.16.4-4.0.3.9

Tsoccerguy3 commented 3 years ago

i tested in single and multi player seems to work , debug.log

Tsoccerguy3 commented 3 years ago

I tested and compiled today's build and it is working. A small mistake in the build.gradle, that throws a error stopping the compile maven { url = 'http://repo.spongepowered.org/maven' } change to this maven { url = 'https://repo.spongepowered.org/maven' }

OreCruncher commented 3 years ago

Yes. They changed the repo access to https recently. I haven't pushed my current build.gradle yet.

Tsoccerguy3 commented 3 years ago

This may or may not be bugs , i could not find a way to fix lightning sound when lighting strikes close to you, the sound is muffled and stops suddenly . Easy to test by trigger lightning to hit a block in front of you . Also i could not find a way to set the aurora in a biome . Is it hard coded to colder biomes ?

OreCruncher commented 3 years ago

I haven't experienced muffling of lightening. I will take a look to make sure I didn't break anything. And there is a way to set auroras for a biome. For resource packs checkout this issue (https://github.com/OreCruncher/DynamicSurroundings/issues/650). It's specific to dimensions.json, but you can put in a biomes.json as well.

For example, if you want to turn on aurora for all biomes you could create a biomes.json and put the following in it. (I do this for testing on my dev box):

[
  {
    "conditions": "true",
    "_comment": "Display aurora",
    "aurora": true
  }
]

If you want to set this without putting it in a resource pack you can drop it into the .minecraft/config/dsurround/configs/dsurround folder. (You may need to create that path.) Make sure you drop it specifically into this path.

OreCruncher commented 3 years ago

The lightning issue appears to be related to occlusion. There will be an option in the next update that has a config option to enable/disable occlusion of the WEATHER sound category, and by default it will be turned off.