[1.20.1] Bug: Logs being spammed

[Arbee4ever]

Whenever I launch my game and have the "Music" Volume slider set to 0%, this mod keeps spamming [19:28:48] [Render thread/INFO]: Play Music: minecraft:music.menu{newSystem false, range 16.000000} into my logs. When I then go into the options and set it to 100% exit the options and set it back to 0%, it doesn't spam anymore, but when I now enter a game it spams the same line only with music.game instead of music.menu. I think this is caused by this line: https://github.com/OreCruncher/DynamicSurroundingsFabric/blob/d9279ec935d62c5c26731012619394fe056cbc5a/src/main/java/org/orecruncher/dsurround/mixins/audio/MixinMusicManager.java#L69

[Arbee4ever]

Also, I'm on version 0.3.3 of this mod and 1.20.1 of minecraft

[Arbee4ever]

(Also would be nice if you changed your logging to always include your modid, as I didn't have anything to go off of in finding what mod did this in my modpack)

[Arbee4ever]

OK, so apparently it only does this in the modpack I'm playing, so it must be another mod causing this mod to malfunction. (I'm playing this modpack if you want to try and find the mod combination causing this: https://modrinth.com/modpack/layncesblueprint (on version 1.1.1))

[OreCruncher]

Not sure how frequent the spamming is. This debug trace is emitted whenever the MusicManager attempts to play situational music. Based on the pack description on Modrinth I suspect Infinite Music. Looking at that mod's code is removes the delay between situational music plays. With a 0% music volume this means it could trigger play every tick. Talk about sound exhaustion. :) My plan is to change my log statement into debug trace.

[Arbee4ever]

After disabling the Infinite Music mod, the spamming stopped. And yes, it was something along the lines of once every tick.