1.18.2 support and fixes

[ThexXTURBOXx]

Fixes #13 Fixes #10

[ThexXTURBOXx]

Heh, you just decided to ignore the exception? Okay, that's a decision, too 😃

Well, until a proper fix is found, it doesn't hurt to ignore it. The channel is released anyways (it is getting released twice in fact which is the issue) ;)

[spnda]

@ThexXTURBOXx no offence, but you could have just made a PR with the style fixes and then notify on my PR that I have to update to 1.18.1, no? PRs are usually meant for a single topic and shouldn't address multiple things imo. Not saying you should close this, I'm just leaving this as a friendly reminder :D I have updated dependencies on my PR now anyway.

[spnda]

Wait, sorry, I apparently did not get a notification about spnda/DynamicSurroundingsFabric#1. I take everything I've said back, you probably just thought I was inactive :D

[ThexXTURBOXx]

@spnda Oh okay, no problem! Yeah, that's pretty annoying that GitHub doesn't notify you about PRs on forks by default. Yes, I thought you may have better things to do, sorry for that misunderstanding! :)

[HarvelsX]

@ThexXTURBOXx, I do not want to be obtrusive, but it seems https://github.com/ThexXTURBOXx/DynamicSurroundingsFabric/pull/2 PR solves the current problem with the crash of the game, during the game there was not a single crash.

[ThexXTURBOXx]

@HarvelsX Well, I didn't get a notification either :) Will look at it asap. Thank you very much!

[spnda]

Yeah, that's pretty annoying that GitHub doesn't notify you about PRs on forks by default.

@ThexXTURBOXx that is a very weird default... Btw, want to cherry-pick the new version of my commit? I did some minor changes, aswell as bumped modmenu to 3.0.1 👍🏻

[ThexXTURBOXx]

@spnda Merged your changes instead of cherry picking them (in order to give full credit), thank you :)

@HarvelsX Same applies to your changes. I also fixed the workflow that you were working on and included it! Thank you very much, your fix seems to be working for me as well!

[ChloeDawn]

The addition of the GitHub Actions workflow feels out of scope for a port

[Lumnati]

in 1.16.4 there where fireflies flying around flowers and now in 1.18.1 fabric they are gone ?

[Lumnati]

also the village sounds are gone why ?

[PlayfulPiano]

Hi this is probably not really useful otherwise to the conversation or bug issues but I've been trying to find where to download the branched 1.18.1 version of dynamic surroundings. It's a little confusing to find if it's even accessible or not here, since there is the 1.18 version on the other main pull (right?) that has the direct link.

Like I know how to do a download through the github action thing but beyond that could someone point me in the right direction? I know it's in beta or alpha or w/e, that's fine because I've had no issue really with the 1.18 version so far and I've just been wanting to update my game to 1.18.1 finally.

Thanks.

[ThexXTURBOXx]

@Lumnati Might have a look at this soon, thanks for noticing!

@pianoboy8 Clone my repo and build the jar yourself :)

[PlayfulPiano]

How do you build the jar?

[HarvelsX]

How do you build the jar?

Here's another way to get this great mod on 1.18.1 here https://github.com/HarvelsX/DynamicSurroundingsFabric/actions/runs/1641972118 These are the latest commits with PR

[PlayfulPiano]

@HarvelsX thank you!!

[Dr-WeiAL]

How do you build the jar?

Here's another way to get this great mod on 1.18.1 here https://github.com/HarvelsX/DynamicSurroundingsFabric/actions/runs/1641972118 These are the latest commits with PR

There seems to be a problem with this version of raindrops?

[ThexXTURBOXx]

My version can be downloaded here: https://github.com/Smokeybear12/DynamicSurroundingsFabric/actions/runs/1703503069 @Smokeybear12 forked my fork and added GitHub Actions. If you encounter the issue there as well, this might need further digging. However, I don't exactly see what's wrong in your picture.

[Dr-WeiAL]

My version can be downloaded here: https://github.com/Smokeybear12/DynamicSurroundingsFabric/actions/runs/1703503069 @Smokeybear12 forked my fork and added GitHub Actions. If you encounter the issue there as well, this might need further digging. However, I don't exactly see what's wrong in your picture.

I tried your two versions, the problem is the same, the specific performance is that the ripples on the water surface are twitching and twitching, and there are no ripples on the water surface in some places

[Skidamek]

My version can be downloaded here: https://github.com/Smokeybear12/DynamicSurroundingsFabric/actions/runs/1703503069 @Smokeybear12 forked my fork and added GitHub Actions. If you encounter the issue there as well, this might need further digging. However, I don't exactly see what's wrong in your picture.

link not work

[ThexXTURBOXx]

link not work

You seem to be too late. He removed his fork. Just use the HarvelsX's verison instead.

[HarvelsX]

There seems to be a problem with this version of raindrops?

@Dr-WeiAL The bug seems to have been fixed, try to use it: https://github.com/HarvelsX/DynamicSurroundingsFabric/suites/5151891727/artifacts/155652131

[Dr-WeiAL]

There seems to be a problem with this version of raindrops?

@Dr-WeiAL The bug seems to have been fixed, try to use it: https://github.com/HarvelsX/DynamicSurroundingsFabric/suites/5151891727/artifacts/155652131

Yes, the ripples in this version are no longer messy, and it looks much more comfortable.

[HarvelsX]

@Dr-WeiAL, it's good that it helped you, but next time create a separate issue (https://github.com/OreCruncher/DynamicSurroundingsFabric/issues) on something.

[Sunconure11]

Does this build have any issues with 1.18.2?

[HarvelsX]

Does this build have any issues with 1.18.2?

I made a commit adding support for 1.18.2, but be careful, it's untested. I would be glad to have your help in testing. https://github.com/HarvelsX/DynamicSurroundingsFabric/tree/1.18

[PlayfulPiano]

Might it at all be possible to get in contact w/orecruncher and see if it is at all possible to upload the recent 1.18/1.18.1/eventual 1.18.2 versions on like curseforge or modrinth so people have easier access to the files (even if they're more in an alpha/beta status?

[ThexXTURBOXx]

Let's phrase it like this: Anyone is permitted to upload it by himself since this mod is under MIT License. So, if someone wants to upload it, go ahead! :)

[Sunconure11]

Would it be possible to put compiled jars in here every so often, for testing purposes?

[ThexXTURBOXx]

They are available here: https://github.com/ThexXTURBOXx/DynamicSurroundingsFabric/actions If you click on the latest build and download the artifact :)

[UmbraVivens]

are these actually Fabric only?

[ThexXTURBOXx]

@Osiris-Team As far as I can see, the build is still available for download

[Osiris-Team]

@ThexXTURBOXx Yeah, but I think only for logged in github users... sry deleted the comment before, since I thought I was wrong, and I don't like being wrong lol

[PlayfulPiano]

welcome back ore

[CormacZ]

Welcome back 😄