Add support for 1.19 - Githubissues

jmattingley23 commented 2 years ago

Adds support for 1.19 / 1.19.2

I don't really expect this to get merged as its bringing in a lot of other commits under it that will make code review a pain but I was able to get this working so I figured I'd at least put it out there for other people to use and to serve as reference for any future development work.

The biggest relevant change in 1.19 seems to be that the concept of biome categories no longer exists. As a short term fix I just used the biome name to map from the old minecraft categories to DynamicSurroundings biome traits, but going forward it would probably be best to move this into some sort of static mapping or migrate away from the concept of biome categories entirely.

coornio commented 2 years ago

Hey there. I wanted to point out that something is pretty darn wrong in 1.19. The engine itself works fine, but none of the biome loops are being played. Can confirm that the 1.18.2 version works properly in comparison. Quick debug screen:

I reckon it has something to do with the biome changes in 1.19. I would be grateful if someone who's definitely more knowledgeable than me could attempt to fix this. I like this mod's sounds much more than AmbientSounds :)

EDIT: Correction, occasionally it decides to play some sounds on loop for no reason too, like minecart sounds at the beach, and guardian attack sounds in a frozen ocean biome. I'll have to take this mod off entirely until this is addressed because it's doing whatever it wants.

cpm9 commented 2 years ago

Can we get a link to a build/action for download? Thanks @jmattingley23 @coornio

coornio commented 2 years ago

Can we get a link to a build/action for download? Thanks @jmattingley23 @coornio

Go to Commits, scroll all the way to the bottom to the last one, click the < > button on it, then opt to download the project source as a zip. Extract the folder somewhere, then open a CMD window at that location and type gradlew build, then wait it out and you'll find the .jar you want in a folder named "binaries" (I might be remembering that wrong).

jmattingley23 commented 2 years ago

Yup that's pretty much the process, here's the one that built when I made the PR: DynamicSurroundings-Fabric-1.19-0.0.4.zip

(edited to update link)

cpm9 commented 2 years ago

Thanks but isn't there a way to make the .jar compiled in github with a build action artifiact something like this older one for 1.18?https://github.com/HarvelsX/DynamicSurroundingsFabric/actions/runs/2406453937

jmattingley23 commented 2 years ago

Hey there. I wanted to point out that something is pretty darn wrong in 1.19. The engine itself works fine, but none of the biome loops are being played. Can confirm that the 1.18.2 version works properly in comparison. Quick debug screen:

Hmm, I'm not totally sure either. This is my first time contributing to the development of this mod so I'm no expert but I assume you're probably right that it has something to do with the biome category changes. I've been playing with the 1.19 version for a little over a week now and haven't personally noticed any issues with incorrect loops playing or missing loops. In the debug screen are you able to see if the biome traits are getting populated correctly? Or if incorrect ones are being added when you notice the wrong sounds playing? 2022-06-21_14 55 21

jmattingley23 commented 2 years ago

Thanks but isn't there a way to make the .jar compiled in github with a build action artifiact something like this older one for 1.18?

~~Good point, here's the one from my fork: https://github.com/jmattingley23/DynamicSurroundingsFabric/actions/runs/2478026253~~

Looks like the artifact expired, here's a direct link: DynamicSurroundings-Fabric-1.19-0.0.4.zip

coornio commented 2 years ago

Hmm, I'm not totally sure either. This is my first time contributing to the development of this mod so I'm no expert but I assume you're probably right that it has something to do with the biome category changes. I've been playing with the 1.19 version for a little over a week now and haven't personally noticed any issues with incorrect loops playing or missing loops. In the debug screen are you able to see if the biome traits are getting populated correctly? Or if incorrect ones are being added when you notice the wrong sounds playing?

It's quite late right now but I can give it another go tomorrow so that I can provide additional info/context.

Some of my experiences include, but are not exclusive to, the minecart/base sound being omnipresent but inaudible (was this always there?? can't be configured either), guardian laser attack sounds in a frozen ocean/spikes biome with no ocean monument in sight (checked with /locate), lack of ambient loops in forests, meadows, and badlands, rain loop over a river with no rain, and sometimes even occasional mob sounds where they weren't present (I have a minimap so I can see them if they're in range). Odd stuff.

Stonehawk commented 2 years ago

Goodness Me, this shows how much of a hopeless n00b I may forever be when it comes to GitHub; I only peeked in the pull requests out of desperation, but it seems you've done exactly what I was hoping someone might have! At least I've learned one new thing today...

Thank you for giving this project a gasp of life; it seems to have needed one badly.

Minecraft just hasn't been the same without Dynamic Surroundings.

kirmerk1 commented 1 year ago

Hmm, I'm not totally sure either. This is my first time contributing to the development of this mod so I'm no expert but I assume you're probably right that it has something to do with the biome category changes. I've been playing with the 1.19 version for a little over a week now and haven't personally noticed any issues with incorrect loops playing or missing loops. In the debug screen are you able to see if the biome traits are getting populated correctly? Or if incorrect ones are being added when you notice the wrong sounds playing?

It's quite late right now but I can give it another go tomorrow so that I can provide additional info/context.

Some of my experiences include, but are not exclusive to, the minecart/base sound being omnipresent but inaudible (was this always there?? can't be configured either), guardian laser attack sounds in a frozen ocean/spikes biome with no ocean monument in sight (checked with /locate), lack of ambient loops in forests, meadows, and badlands, rain loop over a river with no rain, and sometimes even occasional mob sounds where they weren't present (I have a minimap so I can see them if they're in range). Odd stuff.

I got the same problem. Have you found the fix?

Sunconure11 commented 1 year ago

Is this compatible with 1.19.2?

Sunconure11 commented 1 year ago

The cache for these builds is no longer available.

@jmattingley23

jmattingley23 commented 1 year ago

Is this compatible with 1.19.2?

~~I would assume so, I haven't played on 1.19.2 yet though. If it doesn't work let me know and it should be pretty easy to upgrade.~~

Just updated my game, seems to work fine on 1.19.2 with the same .jar

jmattingley23 commented 1 year ago

The cache for these builds is no longer available.

@jmattingley23

Oops, I guess it expires after a while. Here's a direct link to download the .jar:

DynamicSurroundings-Fabric-1.19-0.0.4.zip

If the link dies again you can always build your own copy by downloading the repo and running gradlew build

jmattingley23 commented 1 year ago

New version (1.19-0.0.5)

Includes a few fixes:

Fixed a previously existing NPE in the SoundEventType class which was preventing biome loops and additional ambient sounds from playing
Added a bunch of missing biome traits that were lost in the deprecated categories conversion
Fixed an issue where the debug screen would always show ERROR? on the second line

Here's some screenshots showing the working loops & ambient sounds, as well as additional traits & attributes being populated correctly:

Screenshot 2022-09-14 202247

Screenshot 2022-09-14 202151

Download (tested & working on 1.19.2:

DynamicSurroundings-Fabric-1.19-0.0.5.zip

jmattingley23 commented 1 year ago

@coornio @kirmerk1 I remember you guys were having issues with the previous version, let me know if this new revision addresses the problems you were seeing

coornio commented 1 year ago

@coornio @kirmerk1 I remember you guys were having issues with the previous version, let me know if this new revision addresses the problems you were seeing

MVP?!

Will give it a shot as soon as I have some time <3

Sunconure11 commented 1 year ago

Legally speaking, you could probably upload this to CurseForge. I'd suggest looking into this.

rc6ty commented 1 year ago

Hey, I observed a sound clipping issue recently when beeing near large amounts of flowing water, did anyone else encountered a simlar thing? video demonstrating the problem: https://imgur.com/a/I0tTI2i