OreCruncher / DynamicSurroundingsFabric

Dynamic Surroundings mod for Minecraft
MIT License
63 stars 25 forks source link

[1.20.1] Fabric backport of 1.20.4 #35

Closed Rebel459 closed 6 months ago

Rebel459 commented 7 months ago

Just wanted to start this off with saying thanks for the 1.20 update, this mod’s absolutely incredible. And yes, I know this has only just released for 1.20.4, but it would be absolutely incredible if a 1.20.1 release was possible in the future, as this awesome mod would massively improve so many modpacks, with which all the large ones are forced to use 1.20.1 due to mod availability. Thanks for your time

OreCruncher commented 7 months ago

I am not sure what it would take to get a 1.20.1 version. It was a real pain getting it to 1.20.4. I will to my list when I get a chance - no promises. :)

OreCruncher commented 7 months ago

For what it's worth - the mod seems to run with Minecraft 1.20.3, though the in game sound config menu has some jank. 1.20.2 and earlier would require code changes.

Rebel459 commented 7 months ago

Really appreciate the response and glad to hear you’re happy to consider it! Hopefully it’s not too big a task, but no issue if you don’t end up doing it. Have a good day, and thanks for supporting and developing such a great mod! :)

MarkinhosMLP commented 7 months ago

lets hope its not something too hard, i love the mod but unfortunately other mods and servers i play had not updated to 1.20.2/+

sternschnaube commented 7 months ago

Would love to use the mod on 1.20.2 😊

Thefatsparrow commented 6 months ago

any updates on the backport?

OreCruncher commented 6 months ago

I haven't finished with 1.20.4 ;) I am almost done, though. Once that is completed I will be looking at Forge/Neoforge. Once THAT is done I can evaluate backports.

Thefatsparrow commented 6 months ago

cool keep us updated!

VOLKOUL commented 6 months ago

Forge/NeoForge support for 1.20.1 would be like finding diamonds for the first time.

VOLKOUL commented 6 months ago

Actually, since we have Sinytra Connector, focusing on a backport to 1.20.1 would be a more preferable option imo. That way people wouldn't have to wait as much and you would not have to learn porting to other modloaders.

OreCruncher commented 6 months ago

Not sure if I want to be in a position to support something like Sinytra connector. Though, technically, there shouldn't be anything for me to do I don't want to field support issues involving components like that. I did enough looking at Forge recently and the startup behaviors are different enough to give my mod headaches, and I do not think something like Sinytra would improve things.

This being said, the work I am doing for the next release will simplify any porting I may do, whether to Forge or even earlier versions of Fabric. I did a trial of doing a Fabric 1.20.1 build and it looks pretty reasonable. Once I push the release I am working on I will take a harder look at a Fabric 1.20.1 release.

OreCruncher commented 6 months ago

And I have a 1.20.1 version running. The sound config GUI needs some TLC and I have to do a bunch more testing. Looks promising.

Rebel459 commented 6 months ago

I’m super hyped to see it! Do you want some help testing?

OreCruncher commented 6 months ago

Unfortunately, some of the stuff I am looking for is based on my internal understanding of the mod. The weird corner cases that keep me up at night. :)

Any recommendations for a 1.20.1 modpack? Just ran through Fabulously Optimized. Looking for something that stresses the environment with different things.

Rebel459 commented 6 months ago

You want to stress it? Honestly use mine lmao (Legacies on modrinth), I am planning to use DynamicSurroundings after all I have way too much cursed random niche crap in it, it’s a big (mod-count-wise) pack with over 250 mods That or you could just use the regular old BetterMC etc

Thefatsparrow commented 6 months ago

Install terralith and continents that really stresses and tests your computer

Rebel459 commented 6 months ago

…that’s not remotely what they meant by that

OreCruncher commented 6 months ago

@Rebel459 As an FYI - some of the biomes added by the pack do not have biome tags set so Dynamic Surroundings will not play biome effects in those areas. A datapack can supply the missing tags. When integrating DS into your pack you can do a "/dsdump biomes" to get a list of what DS thinks of the various biomes.

OreCruncher commented 6 months ago

Just pushed the 1.20.1 version to both CurseForge and Modrinth.

Rebel459 commented 6 months ago

Thanks a ton for the heads-up, will do! And thanks so much for the port and the backport, super excited to finally see you and Dynamic Surroundings return!

OreCruncher commented 6 months ago

For what it's worth it seems the 1.20.1 works with the Sinytra mod framework. At least it loaded, I got biome sounds, debug screen, and I get cave reverb.

sternschnaube commented 6 months ago

Is 1.20.2 off the table? 👀

OreCruncher commented 6 months ago

Not sure how many people are on 1.20.2. There are differences between 1.20.1 and .2 that Mojang made that would cause me to have a special build.

sternschnaube commented 6 months ago

If it's not that much work it would be cool, otherwise it's already great that you supported 1.201 😊