search

OreCruncher / DynamicSurroundingsFabric

Dynamic Surroundings mod for Minecraft
MIT License
63 stars 25 forks source link

[1.20.X] Armor footstep accents with Presence Footsteps? #55

Open ArmoredFuzzball opened 6 months ago

ArmoredFuzzball commented 6 months ago

With the current Dynamic Surroundings version, if you install Presence Footsteps too, armor rattling noises when walking are gone, even with the footstep accents enabled (I assume because they all get deactivated internally). Presence Footsteps has no such armor noises, so it would be cool if they still worked!

EDIT: Actually, after restarting my game, now Dynamic Surrounding's footstep accents are entirely overriding Presence Footsteps. It would be cool if I could run PF with DS armor noises (and none of the other footstep noises) somehow.

OreCruncher commented 6 months ago

Armor accents should be playing. Only step related sounds affected by presence footstep is watery step, walking on leaves, and moving through brush. The footstep sounds the mod plays is very small and should not be overriding anything presence footsteps is doing.

Which MC version and loader are you using?

OreCruncher commented 6 months ago

Yeah - I don't think I can work around this without making my life complicated or breaking PF. Basically, to suppress the normal footstep sound processing in Minecraft PF will fudge a data value to be artificially large. Because of this, the logic my footstep accent logic taps into will be bypassed.

ArmoredFuzzball commented 6 months ago

Sorry I was asleep. I'm using 1.20.2 (technically unsupported I know) with your 1.20.1 version of the mod, with fabric loader version 15.3. I figured this may be a significant change that isn't worth it, so thanks anyway for looking into it.

ArmoredFuzzball commented 6 months ago

Guess I should take this to PF and see if they can make their mod more compatible

OreCruncher commented 6 months ago

You could, but I don't think there is anything they can do. I did the same thing with my footstep sound acoustics way back when. It's a non-complex way to make Minecraft not play footstep sounds for an entity. Modern Minecraft things are more complicated which makes it the best way.

ArmoredFuzzball commented 6 months ago

I see, thanks for the info then. Feel free to close this.

OreCruncher commented 6 months ago

I'll leave open for now. Something may occur to me.