search

OreCruncher / DynamicSurroundingsFabric

Dynamic Surroundings mod for Minecraft
MIT License
65 stars 25 forks source link

Game crashes when exiting a minecraft world #7

Closed 2003HondaAccord closed 2 years ago

2003HondaAccord commented 2 years ago

whenever im using the mod (version 0.0.3 and earlier), when exiting a minecraft world the game crashes with this mouseClicked event handler error and exit code -1

crash-2021-10-20_11.34.28-client.txt

OreCruncher commented 2 years ago

I have seen this as well. About 50/50 chance of getting this error when exiting. What's strange is that I do not have any hooks along these code paths.

OreCruncher commented 2 years ago

I am going to be making a speculative fix. I am moving the hook location of my deinit code to occur before the MC sound engine shuts down its processing on world exit. My theory is that my processing threads may have tripped over this problem, but because how OpenAL works the client thread will pick up the error thus causing this exception.

OreCruncher commented 2 years ago

Pushed 0.0.4.

jdamboeck commented 2 years ago

Still crashing for me