OreCruncher / DynamicSurroundingsFabric

Dynamic Surroundings mod for Minecraft
MIT License
62 stars 25 forks source link

[1.20.x] Biome sounds not working when connecting to Paper server #76

Closed DJHardLogic closed 5 months ago

DJHardLogic commented 5 months ago

The biome sounds (such as ocean waves, birds chirping, crickets at night, etc.) don't work when I'm on a server, but other sounds like the wind at high altitudes and crows cawing do work. All the sounds work properly on singleplayer worlds.

OreCruncher commented 5 months ago

Modpack, server type, etc. Also do you have ModernFix installed? Also which version of DS?

DJHardLogic commented 5 months ago

1.20.4-0.3.1 No I don't have ModernFix. Should I install that?

DJHardLogic commented 5 months ago

I have added ModernFix and it's just the same as before

OreCruncher commented 5 months ago

No - there was a bug in ModernFix that was recently fixed that could have affected scanning of resources. What server are you connecting to? Vanilla, Fabric, etc? Also what modpack? In my environment I can connect to a vanilla server hosted on LAN without problems.

EDIT: If you could, enable the DS Diagnostics Overlay in key binds, and while in game attached to the server activate the overlay. Take a screen shot and post here.

EDIT2: And the obvious question - the AMBIENT sound volume setting in Sound Options is set to?

DJHardLogic commented 5 months ago

2024-02-04_13 47 13 2024-02-04_13 48 07 I'm not sure what you mean by modpack, but I play on a mostly vanilla "paper" server. We have some plugins, but they're all just anti-cheat/anti-theft

OreCruncher commented 5 months ago

Hmm...paper. What Fabric loader and API version? I have a suspicion.

DJHardLogic commented 5 months ago

fabric-installer-1.0.0 and fabric-api-0.93.1+1.20.4

OreCruncher commented 5 months ago

Can you update Fabric API to the latest for 1.20.4? Should be 0.95.4+1.20.4. Reason is there were fixes for the API firing the tag load event when a client joins. I suspect that is not happening based on the screenshot you provided.

DJHardLogic commented 5 months ago

2024-02-04_14 50 07 Updated, but no change

DJHardLogic commented 5 months ago

2024-02-04_14 52 42 Here's another biome at a different time of day. Don't know if that provides any more help

OreCruncher commented 5 months ago

I'm going to have to dig into this. For whatever reason the biome information I have cached during client connect is not matching the reality of the game play. My mod uses biome tags to determine which effects to play for a given biome. This biome tag analysis shows up as "Biome Traits" in the diagnostic overlay (roughly the 8th written line in the screen shot).

(I recall similar issues with Paper servers in the past - not sure as to the why's.)

OreCruncher commented 5 months ago

I have a fix. Need to do more testing.

OreCruncher commented 5 months ago

Pushed update to CurseForge and Modrinth. CurseForge is dragging its feet per usual.