[OpenEye] Potential crash during initial world gen

OreCruncher / ThermalRecycling

Thermal Expansion add-on for recycling

MIT License

10 stars 7 forks source link

[OpenEye] Potential crash during initial world gen #57

Closed OreCruncher closed 9 years ago

OreCruncher commented 9 years ago

If a world is being initialized for the first time it is possible to experience a crash. The specific case is when Tinkers is generating oreberry bushes and breaks a Pile of Rubble in the process. At this point in time during startup the loot table for the Pile of Rubble is empty causing the weighted random routines in Minecraft to bonkers. They don't like a total weight of 0. :\

The current unpalatable workarounds are:

Regen the world. Since the world is first starting it may not be a big deal.
Disable Pile of Rubble in the config file.

OreCruncher commented 9 years ago

Published release.

spannerman79 commented 9 years ago

Issue still occurs in v0.4.2.4

java.lang.IllegalArgumentException
    at net.minecraft.util.WeightedRandom.func_76269_a(WeightedRandom.java:82)
    at net.minecraft.util.WeightedRandom.func_76274_a(WeightedRandom.java:113)
    at net.minecraftforge.common.ChestGenHooks.getOneItem(ChestGenHooks.java:240)
    at org.blockartistry.mod.ThermalRecycling.blocks.PileOfRubble.func_149749_a(PileOfRubble.java:118)

OreCruncher commented 9 years ago

Do you have a more complete call stack?

spannerman79 commented 9 years ago

Was using ThermalRecycling-1.7.10-0.4.2.3.jar - not the just updated release to CurseForge.

Please ignore and close - my bad. Sorry.

OreCruncher commented 9 years ago

lol - try the new one and let me know. :)

spannerman79 commented 9 years ago

:ok_hand: all good :smile: