search

OreCruncher / ThermalRecycling

Thermal Expansion add-on for recycling
MIT License
10 stars 7 forks source link

Waila tooltip seems incorrect for the vending machine #80

Closed mrammy closed 8 years ago

mrammy commented 8 years ago

It appears as a machine block and an unlocalized name. The bottom of the block appears to be fine and show the proper rendering top: bottom:

Am I correct in assuming these should be the same?

OreCruncher commented 8 years ago

No, actually they are different blocks. The top block is a gag block that is invisible. Regardless, this should be easy to address. Thanks for reporting.

What version of Waila and Thermal Recycling are you using?

mrammy commented 8 years ago

Waila 1.5.10 and Thermal Recycling 1.0.2.4 from Curse. I meant same as in same tooltip not the same block sorry if there was any misinformation I contributed there.

OreCruncher commented 8 years ago

Interesting...using 1.5.10 as well and my BETA build. I don't see the problem. Hmm.

EDIT: What are the other Waila related add-ons that you have installed?

EDIT2: There is special code in the TR Waila handler to proxy out the Vending Machine if the player is looking at the top vending block. Do you have a config item set somewhere that disables this behavior? Another example of this is how Waila hides the Monster Egg blocks from casual detection.

OreCruncher commented 8 years ago

Any further information related to my questions above? :)

mrammy commented 8 years ago

I'm still having a hard time tracking this one down

OreCruncher commented 8 years ago

Do you have a list of Waila add-ons that are installed? I noticed Harvestability - wondering if there is anything else.

mrammy commented 8 years ago

Are you on IRC or Skype? maybe instant message is a better place to conduct a conversation about this

OreCruncher commented 8 years ago

No, I don't do Skype and I do not have an IRC. What you could do is paste a link to the client log file generated by Forge. Should answer a lot of my questions.

mrammy commented 8 years ago

fml-client-latest.log for 1.0.3.4 and 1.0.2.4 separated by "-v1.0.3.4 break" waila.cfg

before and after pictures of v1.0.3.4 Beta. The actual block still doesn't appear.

Could it potentially be NEI related? I'm using the latest version of NEI on curseforge. Seems a little weird to only affect your mod though...

OreCruncher commented 8 years ago

Sorry for not seeing your response sooner. Apparently I am not getting a notification when you update. :\

Based on the log my mod is not getting a callback from Waila to register it's needs. This means that my mod is not hooked into Waila, thus it is unable to handle the vending top. What my mod does is replace the vending top block with the vending bottom for purposes of Waila.

Normally you should see this line in the log file:

[10:12:09] [Client thread/INFO] [Waila/Waila]: Receiving registration request from [ recycling ] for method org.blockartistry.mod.ThermalRecycling.waila.WailaHandler.callbackRegister

Dumb question, but is Waila enabled in the recycling.cfg file?

# Enables/disables display of scrap information via Waila [default: true] B:"Enable Waila Display"=true

mrammy commented 8 years ago

I apologize I thought that was for display of scrap only. It's working now, sorry for all the fuss for basically no reason.

OreCruncher commented 8 years ago

No worries. This may be indicative of the confusion about the settings. It may be a good idea to have a separate setting specifically for enable/disable Waila, and a separate one for the scrap. I am going to reopen to track.

OreCruncher commented 8 years ago

Btw, the Enable Tooltips option is the one that governs the display of the "Scrap Value" lines in the Waila HUD. Setting to false should turn it off.

mrammy commented 8 years ago

Fine with me :). I did want them on just with shift which there's a waila.cfg for. Don't know how that got turned off

OreCruncher commented 8 years ago

Posted fix to CurseForge: http://minecraft.curseforge.com/projects/thermal-recycling/files/2269594